Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): use moduleGraph.getIssuer to avoid deprecation warning (#36329) #36330

Merged
merged 3 commits into from Apr 21, 2022

Conversation

await-ovo
Copy link
Contributor

fix: #36329

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, since a reproduction is available could you add a test for this behavior: https://github.com/vercel/next.js/blob/canary/test/readme.md

@await-ovo
Copy link
Contributor Author

The change looks good, since a reproduction is available could you add a test for this behavior: https://github.com/vercel/next.js/blob/canary/test/readme.md

Okay, I will add the related test cases :)

@await-ovo
Copy link
Contributor Author

await-ovo commented Apr 21, 2022

Test cases have been added. :)

I also initialized cliOuput at the next start to avoid undefined at the beginning of the output string.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk requested a review from timneutkens April 21, 2022 13:45
@ijjk
Copy link
Member

ijjk commented Apr 21, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
buildDuration 19s 19.5s ⚠️ +450ms
buildDurationCached 7.5s 7.5s ⚠️ +18ms
nodeModulesSize 481 MB 481 MB ⚠️ +226 B
Page Load Tests Overall increase ✓
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
/ failed reqs 0 0
/ total time (seconds) 3.896 3.87 -0.03
/ avg req/sec 641.75 646.07 +4.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.741 1.625 -0.12
/error-in-render avg req/sec 1435.72 1538.21 +102.49
Client Bundles (main, webpack)
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
buildDuration 21.5s 21.6s ⚠️ +66ms
buildDurationCached 7.4s 7.5s ⚠️ +103ms
nodeModulesSize 481 MB 481 MB ⚠️ +226 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
/ failed reqs 0 0
/ total time (seconds) 3.923 3.937 ⚠️ +0.01
/ avg req/sec 637.23 635.03 ⚠️ -2.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.661 1.7 ⚠️ +0.04
/error-in-render avg req/sec 1505.28 1470.98 ⚠️ -34.3
Client Bundles (main, webpack)
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary await-ovo/next.js fix-webpack-issuer-warning Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 1d02177

@kodiakhq kodiakhq bot merged commit 864d401 into vercel:canary Apr 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API
3 participants