Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client HMR tracing for debugging #36328

Merged
merged 1 commit into from Apr 21, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 21, 2022

This adds client HMR event tracing to help debug the client state for reproductions easier

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 21, 2022
@ijjk ijjk marked this pull request as ready for review April 21, 2022 03:03
@ijjk
Copy link
Member Author

ijjk commented Apr 21, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/client-traces Change
buildDuration 15.7s 15.5s -172ms
buildDurationCached 6.1s 6.1s -4ms
nodeModulesSize 485 MB 485 MB ⚠️ +8.04 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/client-traces Change
/ failed reqs 0 0
/ total time (seconds) 3.048 3.023 -0.02
/ avg req/sec 820.19 827.07 +6.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.185 1.164 -0.02
/error-in-render avg req/sec 2108.94 2147.57 +38.63
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/client-traces Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/client-traces Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/client-traces Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/client-traces Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/client-traces Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/client-traces Change
buildDuration 18.1s 18.1s ⚠️ +39ms
buildDurationCached 6.1s 6s -94ms
nodeModulesSize 485 MB 485 MB ⚠️ +8.04 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/client-traces Change
/ failed reqs 0 0
/ total time (seconds) 3.029 3.004 -0.02
/ avg req/sec 825.47 832.25 +6.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.156 1.163 ⚠️ +0.01
/error-in-render avg req/sec 2162.79 2149.54 ⚠️ -13.25
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/client-traces Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/client-traces Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/client-traces Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/client-traces Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/client-traces Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 8bbb67d

@kodiakhq kodiakhq bot merged commit b5d9ce5 into vercel:canary Apr 21, 2022
@ijjk ijjk deleted the add/client-traces branch April 21, 2022 12:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants