Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure beforeFiles client-side resolving handles dynamic routes #36317

Merged
merged 2 commits into from Apr 21, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 20, 2022

This fixes resolving beforeFiles rewrites with next/link as previously we weren't resolving the destination to a dynamic route since the resolving was being marked as finished when it shouldn't be during beforeFiles.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #35402

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 20, 2022
@ijjk ijjk marked this pull request as ready for review April 20, 2022 16:52
@ijjk
Copy link
Member Author

ijjk commented Apr 20, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
buildDuration 14.8s 14.9s ⚠️ +145ms
buildDurationCached 6.1s 5.6s -496ms
nodeModulesSize 481 MB 481 MB -41 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
/ failed reqs 0 0
/ total time (seconds) 3.077 3.105 ⚠️ +0.03
/ avg req/sec 812.54 805.04 ⚠️ -7.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.363 1.374 ⚠️ +0.01
/error-in-render avg req/sec 1834.42 1819.96 ⚠️ -14.46
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
buildDuration 16.6s 17.8s ⚠️ +1.2s
buildDurationCached 5.8s 6s ⚠️ +207ms
nodeModulesSize 481 MB 481 MB -41 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
/ failed reqs 0 0
/ total time (seconds) 2.962 3.205 ⚠️ +0.24
/ avg req/sec 843.89 779.95 ⚠️ -63.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.394 1.326 -0.07
/error-in-render avg req/sec 1792.85 1885.88 +93.03
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/before-files-resolving Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 5be069a

@ijjk ijjk requested a review from styfle April 20, 2022 18:18
@kodiakhq kodiakhq bot merged commit 6da7132 into vercel:canary Apr 21, 2022
@ijjk ijjk deleted the fix/before-files-resolving branch April 21, 2022 14:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard rewrites (/x/:path*) are causing page reloads
3 participants