Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/jest: Allow moduleNameMapper to match before Next.js internal mappings #36312

Merged
merged 1 commit into from Apr 20, 2022

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Apr 20, 2022

Fixes #35634

This change doesn't require tests as importing svgs is not a supported feature, this just makes it slightly more ergonomic to override the matchers.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Apr 20, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/35634 Change
buildDuration 15.2s 15.2s -27ms
buildDurationCached 6s 5.9s -15ms
nodeModulesSize 485 MB 485 MB ⚠️ +146 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/35634 Change
/ failed reqs 0 0
/ total time (seconds) 3.002 3.008 ⚠️ +0.01
/ avg req/sec 832.79 831.17 ⚠️ -1.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.16 1.173 ⚠️ +0.01
/error-in-render avg req/sec 2155.54 2130.51 ⚠️ -25.03
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js fix/35634 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/35634 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/35634 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/35634 Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/35634 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/35634 Change
buildDuration 17.9s 17.9s -39ms
buildDurationCached 6s 6s ⚠️ +25ms
nodeModulesSize 485 MB 485 MB ⚠️ +146 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/35634 Change
/ failed reqs 0 0
/ total time (seconds) 3.019 3.011 -0.01
/ avg req/sec 828.04 830.23 +2.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.154 1.159 ⚠️ +0.01
/error-in-render avg req/sec 2166.2 2156.78 ⚠️ -9.42
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js fix/35634 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/35634 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/35634 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/35634 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/35634 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 89d53e6

@kodiakhq kodiakhq bot merged commit 23c82e4 into vercel:canary Apr 20, 2022
@timneutkens timneutkens deleted the fix/35634 branch April 20, 2022 15:48
sabertazimi added a commit to sabertazimi/blog that referenced this pull request May 6, 2022
Rectify Jest configuration for renovate-bot #814 pull request.

close #815
issue vercel/next.js#35634
issue vercel/next.js#36312
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next/Jest : Cannot override transformIgnorePatterns
2 participants