Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for image config formats (avif/webp) #36289

Merged
merged 2 commits into from Apr 19, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Apr 19, 2022

This PR adds telemetry for image config formats since AVIF is opt-in (#30180).

See docs https://nextjs.org/docs/api-reference/next/image#acceptable-formats

@ijjk
Copy link
Member

ijjk commented Apr 19, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
buildDuration 18.7s 18.8s ⚠️ +95ms
buildDurationCached 7.2s 7.1s -32ms
nodeModulesSize 485 MB 485 MB ⚠️ +334 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
/ failed reqs 0 0
/ total time (seconds) 3.772 3.786 ⚠️ +0.01
/ avg req/sec 662.86 660.37 ⚠️ -2.49
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.597 1.592 0
/error-in-render avg req/sec 1565.68 1570.33 +4.65
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
buildDuration 21.4s 21.3s -40ms
buildDurationCached 7.3s 7.3s
nodeModulesSize 485 MB 485 MB ⚠️ +334 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
/ failed reqs 0 0
/ total time (seconds) 3.818 3.763 -0.06
/ avg req/sec 654.76 664.44 +9.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.628 1.643 ⚠️ +0.02
/error-in-render avg req/sec 1535.62 1521.55 ⚠️ -14.07
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-telemetry-next-image-formats Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: c61d63a

@kodiakhq kodiakhq bot merged commit 835aeae into canary Apr 19, 2022
@kodiakhq kodiakhq bot deleted the add-telemetry-next-image-formats branch April 19, 2022 22:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants