Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #36269

Merged
merged 12 commits into from Apr 21, 2022
Merged

Update swc #36269

merged 12 commits into from Apr 21, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 19, 2022

This PR updates swc crates to swc-project/swc@33e4661

I'll undraft this after verifying some more fixes.

image

image

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 19, 2022
@ijjk
Copy link
Member

ijjk commented Apr 19, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-up-7 Change
buildDuration 15.4s 15.3s -123ms
buildDurationCached 6.1s 6s -144ms
nodeModulesSize 481 MB 481 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-7 Change
/ failed reqs 0 0
/ total time (seconds) 3.05 3.074 ⚠️ +0.02
/ avg req/sec 819.62 813.18 ⚠️ -6.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.2 1.211 ⚠️ +0.01
/error-in-render avg req/sec 2083.03 2064.49 ⚠️ -18.54
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-7 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-7 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-7 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-7 Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-7 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js swc-up-7 Change
buildDuration 17.4s 17.5s ⚠️ +43ms
buildDurationCached 6.1s 6s -118ms
nodeModulesSize 481 MB 481 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-7 Change
/ failed reqs 0 0
/ total time (seconds) 3.013 2.997 -0.02
/ avg req/sec 829.81 834.03 +4.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.189 1.183 -0.01
/error-in-render avg req/sec 2101.97 2113.33 +11.36
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-7 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-7 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-7 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-7 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-7 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: bc98047

@kdy1 kdy1 marked this pull request as ready for review April 21, 2022 10:33
@kodiakhq kodiakhq bot merged commit 9456fc6 into vercel:canary Apr 21, 2022
@kdy1 kdy1 deleted the swc-up-7 branch April 21, 2022 12:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants