Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type definition for defaultGetInitialProps #36252

Merged
merged 2 commits into from Apr 19, 2022

Conversation

seanparmelee
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

This PR fixes #36247 by adding the optional options object to the type definition for DocumentContext.defaultGetInitialProps.

@ijjk
Copy link
Member

ijjk commented Apr 19, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary seanparmelee/next.js 36247 Change
buildDuration 15.3s 15.2s -113ms
buildDurationCached 6s 6.1s ⚠️ +65ms
nodeModulesSize 485 MB 485 MB ⚠️ +43 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary seanparmelee/next.js 36247 Change
/ failed reqs 0 0
/ total time (seconds) 3.011 3.007 0
/ avg req/sec 830.16 831.39 +1.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.167 1.184 ⚠️ +0.02
/error-in-render avg req/sec 2142.3 2112.18 ⚠️ -30.12
Client Bundles (main, webpack)
vercel/next.js canary seanparmelee/next.js 36247 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary seanparmelee/next.js 36247 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary seanparmelee/next.js 36247 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary seanparmelee/next.js 36247 Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary seanparmelee/next.js 36247 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary seanparmelee/next.js 36247 Change
buildDuration 17.8s 17.9s ⚠️ +62ms
buildDurationCached 6s 6s -10ms
nodeModulesSize 485 MB 485 MB ⚠️ +43 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary seanparmelee/next.js 36247 Change
/ failed reqs 0 0
/ total time (seconds) 2.997 3.004 ⚠️ +0.01
/ avg req/sec 834.17 832.28 ⚠️ -1.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.15 1.164 ⚠️ +0.01
/error-in-render avg req/sec 2173.89 2148.02 ⚠️ -25.87
Client Bundles (main, webpack)
vercel/next.js canary seanparmelee/next.js 36247 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary seanparmelee/next.js 36247 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary seanparmelee/next.js 36247 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary seanparmelee/next.js 36247 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary seanparmelee/next.js 36247 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 98b5887

@kodiakhq kodiakhq bot merged commit ffdb9f8 into vercel:canary Apr 19, 2022
@seanparmelee seanparmelee deleted the 36247 branch April 19, 2022 15:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The DocumentContext.defaultGetInitialProps type is missing the optional options argument
3 participants