Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use renderToStaticMarkup to render documentHTML #36213

Merged
merged 3 commits into from Apr 19, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Apr 16, 2022

There wasn't a strong reason to choose renderToStream over renderToStaticMarkup for the document wrapper. But due to problems like #35870, we can switch back to the static renderer for now.

Fixes #35870.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Apr 16, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/0b33 Change
buildDuration 15.2s 14.7s -493ms
buildDurationCached 5.9s 5.9s -77ms
nodeModulesSize 485 MB 485 MB -543 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/0b33 Change
/ failed reqs 0 0
/ total time (seconds) 3.118 2.945 -0.17
/ avg req/sec 801.89 848.77 +46.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.376 1.25 -0.13
/error-in-render avg req/sec 1817.44 2000.12 +182.68
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/0b33 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/0b33 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/0b33 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/0b33 Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/0b33 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/0b33 Change
buildDuration 17.6s 17.1s -484ms
buildDurationCached 5.6s 6.1s ⚠️ +470ms
nodeModulesSize 485 MB 485 MB -543 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/0b33 Change
/ failed reqs 0 0
/ total time (seconds) 3.171 2.923 -0.25
/ avg req/sec 788.28 855.37 +67.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.385 1.329 -0.06
/error-in-render avg req/sec 1804.78 1880.5 +75.72
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/0b33 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/0b33 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/0b33 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/0b33 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/0b33 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 5994ad0

timneutkens
timneutkens previously approved these changes Apr 19, 2022
@kodiakhq kodiakhq bot merged commit 90d3478 into vercel:canary Apr 19, 2022
@shuding shuding deleted the shu/0b33 branch April 19, 2022 18:08
ivan-aksamentov added a commit to nextstrain/nextclade that referenced this pull request May 12, 2022
Upgrades Next.js to version that fixes HTML comment showing up in the browser tab title.

See:
 - vercel/next.js#35870
 - vercel/next.js#36213
 - facebook/react#24263
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

title issue with react-18
4 participants