Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build activity indicator position #36208

Merged
merged 5 commits into from Apr 16, 2022
Merged

Fix build activity indicator position #36208

merged 5 commits into from Apr 16, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 16, 2022

This updates #35137 to allow landing as the existing PR has updates from maintainers disabled so we can't update the branch.

Closes: #35137

stovmascript and others added 4 commits March 10, 2022 13:24
@stovmascript
Fix build activity indicator position
288af82 
`devIndicators.buildActivityPosition` introduced in
vercel#30109 needed more tweaks to properly
position the build indicator container. The build indicator was being rendered
off screen when set to a non-default position.
@stovmascript
Refactor stuff for smaller diff
5694f07
@ijjk
add config validation
2ba578c
@ijjk
Merge branch 'canary' into fix-build-activity-position
5928042
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 16, 2022
@ijjk ijjk changed the title land(Fix build activity indicator position) Fix build activity indicator position Apr 16, 2022
@ijjk
Copy link
Member Author

ijjk commented Apr 16, 2022 •
edited

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
buildDuration 16.2s 16.4s ⚠️ +188ms
buildDurationCached 6.3s 6.2s -88ms
nodeModulesSize 485 MB 485 MB ⚠️ +1.06 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.293 3.303 ⚠️ +0.01
/ avg req/sec 759.28 756.96 ⚠️ -2.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.394 1.426 ⚠️ +0.03
/error-in-render avg req/sec 1793.17 1753.01 ⚠️ -40.16
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.3 kB 28.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72 kB 72 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.04 kB 3.04 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.74 kB 5.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.36 kB 2.36 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
_buildManifest.js gzip 461 B 461 B ✓
Overall change 461 B 461 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
index.html gzip 530 B 530 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
buildDuration 18.9s 19.2s ⚠️ +257ms
buildDurationCached 6.2s 6.3s ⚠️ +57ms
nodeModulesSize 485 MB 485 MB ⚠️ +1.06 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.295 3.291 0
/ avg req/sec 758.8 759.54 +0.74
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.416 1.414 0
/error-in-render avg req/sec 1766.02 1768.25 +2.23
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.7 kB 28.7 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.6 kB 72.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 325 B 325 B ✓
dynamic-HASH.js gzip 3.02 kB 3.02 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.78 kB 5.78 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.44 kB 2.44 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 393 B 393 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.1 kB 16.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix-build-activity-position Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: a0167fe

@ijjk ijjk marked this pull request as ready for review April 16, 2022 04:52
@ijjk ijjk merged commit 63230eb into vercel:canary Apr 16, 2022
@ijjk ijjk deleted the fix-build-activity-position branch April 16, 2022 04:53
SukkaW pushed a commit to SukkaW/next.js that referenced this pull request Apr 18, 2022
@ijjk @stovmascript @SukkaW
Fix build activity indicator position (vercel#36208)
f7963f2 
* Fix build activity indicator position

`devIndicators.buildActivityPosition` introduced in
vercel#30109 needed more tweaks to properly
position the build indicator container. The build indicator was being rendered
off screen when set to a non-default position.

* Refactor stuff for smaller diff

* add config validation

* Apply suggestions from code review

Co-authored-by: Martin Šťovíček <martin.stovicek@monitora.cz>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle styfle is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @stovmascript