Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsc: skip next builtin module when apply loaders #36202

Merged
merged 8 commits into from Apr 17, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 15, 2022

x-ref: vercel/server-components-notes-demo#17

Previously in #35975 we ignore handling node_modules as a workaround for 3rd party packages, but for next buildin components we should still handle them for processing client components

@ijjk
Copy link
Member

ijjk commented Apr 15, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
buildDuration 21.2s 21.3s ⚠️ +103ms
buildDurationCached 7.9s 7.8s -56ms
nodeModulesSize 485 MB 485 MB -385 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
/ failed reqs 0 0
/ total time (seconds) 4.498 4.483 -0.02
/ avg req/sec 555.81 557.71 +1.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.109 2.108 0
/error-in-render avg req/sec 1185.53 1186.24 +0.71
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
buildDuration 24.7s 24.5s -262ms
buildDurationCached 7.8s 8.1s ⚠️ +312ms
nodeModulesSize 485 MB 485 MB -385 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
/ failed reqs 0 0
/ total time (seconds) 4.535 4.566 ⚠️ +0.03
/ avg req/sec 551.26 547.47 ⚠️ -3.79
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.13 2.263 ⚠️ +0.13
/error-in-render avg req/sec 1173.46 1104.6 ⚠️ -68.86
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/skip-next-builtin Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 23b7b26

@huozhi huozhi requested a review from shuding April 16, 2022 00:47
@kodiakhq kodiakhq bot merged commit d895a50 into vercel:canary Apr 17, 2022
@huozhi huozhi deleted the rsc/skip-next-builtin branch April 17, 2022 22:29
SukkaW pushed a commit to SukkaW/next.js that referenced this pull request Apr 18, 2022
x-ref: vercel/server-components-notes-demo#17

Previously in vercel#35975 we ignore handling node_modules as a workaround for 3rd party packages, but for next buildin components we should still handle them for processing client components
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants