Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tsconfig moduleResolution node | node12 | nodenext #36189

Merged
merged 9 commits into from Apr 15, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Apr 15, 2022

@ijjk
Copy link
Member

ijjk commented Apr 15, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
buildDuration 16.2s 16.6s ⚠️ +362ms
buildDurationCached 6.4s 6.3s -149ms
nodeModulesSize 485 MB 485 MB ⚠️ +3.23 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
/ failed reqs 0 0
/ total time (seconds) 3.381 3.32 -0.06
/ avg req/sec 739.5 752.93 +13.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.393 1.416 ⚠️ +0.02
/error-in-render avg req/sec 1794.5 1765.7 ⚠️ -28.8
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
index.html gzip 531 B 531 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
buildDuration 19.3s 19.1s -166ms
buildDurationCached 6.2s 6.2s ⚠️ +6ms
nodeModulesSize 485 MB 485 MB ⚠️ +3.23 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
/ failed reqs 0 0
/ total time (seconds) 3.324 3.293 -0.03
/ avg req/sec 752.2 759.08 +6.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.428 1.407 -0.02
/error-in-render avg req/sec 1750.2 1776.43 +26.23
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js tsconfig-node12-nodenext Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 04e5ac9

timneutkens
timneutkens previously approved these changes Apr 15, 2022
ijjk
ijjk previously approved these changes Apr 15, 2022
@ijjk ijjk dismissed stale reviews from timneutkens and themself via 0796a64 April 15, 2022 15:37
@styfle styfle changed the title Add suppport for tsconfig moduleResolution node | node12 | nodenext Add support for tsconfig moduleResolution node | node12 | nodenext Apr 15, 2022
@kodiakhq kodiakhq bot merged commit 4c15f89 into canary Apr 15, 2022
@kodiakhq kodiakhq bot deleted the tsconfig-node12-nodenext branch April 15, 2022 17:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next (canary) does not support the upcoming TypeScript 4.7 NodeNext/Node12 moduleResolution
3 participants