Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix res.json support for string / null #36186

Merged
merged 2 commits into from Apr 15, 2022

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Apr 15, 2022

Continuation of #33592 with updates tests / changes, see the description there.

Fixes #21749.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Continuation of vercel#33592 with updates tests / changes.

Co-Authored-By: Balázs Orbán <info@balazsorban.com>
@ijjk
Copy link
Member

ijjk commented Apr 15, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
buildDuration 15.8s 15.7s -44ms
buildDurationCached 6.2s 6.1s -62ms
nodeModulesSize 484 MB 484 MB ⚠️ +39 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
/ failed reqs 0 0
/ total time (seconds) 3.104 3.091 -0.01
/ avg req/sec 805.49 808.7 +3.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.228 1.241 ⚠️ +0.01
/error-in-render avg req/sec 2036.32 2013.77 ⚠️ -22.55
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
index.html gzip 531 B 531 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
buildDuration 18.7s 18.8s ⚠️ +133ms
buildDurationCached 6.2s 6.2s -35ms
nodeModulesSize 484 MB 484 MB ⚠️ +39 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
/ failed reqs 0 0
/ total time (seconds) 3.095 3.106 ⚠️ +0.01
/ avg req/sec 807.82 805.02 ⚠️ -2.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.243 1.243
/error-in-render avg req/sec 2010.67 2011.75 +1.08
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/fix-33592 Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 5b6f041

@timneutkens timneutkens merged commit 1582e11 into vercel:canary Apr 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

res.json("string") is not working as expected
3 participants