Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-config-next] Update @typescript-eslint/parser to v5.19.0 #36156

Merged
merged 3 commits into from Apr 15, 2022
Merged

[eslint-config-next] Update @typescript-eslint/parser to v5.19.0 #36156

merged 3 commits into from Apr 15, 2022

Conversation

ytkg
Copy link
Contributor

@ytkg ytkg commented Apr 14, 2022

fixes #35784

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ytkg ytkg changed the title [eslint-config-next]Update @typescript-eslint/parser to v5.19.0 [eslint-config-next] Update @typescript-eslint/parser to v5.19.0 Apr 14, 2022
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine if tests pass.

@ijjk
Copy link
Member

ijjk commented Apr 15, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
buildDuration 15.9s 16s ⚠️ +156ms
buildDurationCached 6.1s 6.1s ⚠️ +11ms
nodeModulesSize 485 MB 485 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
/ failed reqs 0 0
/ total time (seconds) 3.273 3.206 -0.07
/ avg req/sec 763.86 779.91 +16.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.34 1.362 ⚠️ +0.02
/error-in-render avg req/sec 1865.6 1835.52 ⚠️ -30.08
Client Bundles (main, webpack)
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
index.html gzip 531 B 531 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
buildDuration 18.8s 18.6s -177ms
buildDurationCached 6.2s 6.2s -2ms
nodeModulesSize 485 MB 485 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
/ failed reqs 0 0
/ total time (seconds) 3.288 3.241 -0.05
/ avg req/sec 760.23 771.27 +11.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.411 1.375 -0.04
/error-in-render avg req/sec 1772.4 1817.63 +45.23
Client Bundles (main, webpack)
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ytkg/next.js update-typescript-eslint-parser Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 3b1ff5d

@kodiakhq kodiakhq bot merged commit 84d97b1 into vercel:canary Apr 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] TypeScript 4.6 ESLint Warning
3 participants