Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reogranize the client component detection utils #36135

Merged
merged 2 commits into from Apr 13, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 13, 2022

Refactor:

  • group client components detction util
  • add next script as rsc client component

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 13, 2022
@ijjk
Copy link
Member

ijjk commented Apr 13, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/client-utils Change
buildDuration 21.9s 22s ⚠️ +138ms
buildDurationCached 8.3s 8.4s ⚠️ +58ms
nodeModulesSize 484 MB 484 MB ⚠️ +1.16 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js rsc/client-utils Change
/ failed reqs 0 0
/ total time (seconds) 4.775 4.704 -0.07
/ avg req/sec 523.53 531.47 +7.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.211 2.213 0
/error-in-render avg req/sec 1130.96 1129.83 ⚠️ -1.13
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js rsc/client-utils Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/client-utils Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js rsc/client-utils Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/client-utils Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/client-utils Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/client-utils Change
buildDuration 25.7s 25.5s -184ms
buildDurationCached 8.2s 8.5s ⚠️ +239ms
nodeModulesSize 484 MB 484 MB ⚠️ +1.16 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js rsc/client-utils Change
/ failed reqs 0 0
/ total time (seconds) 4.818 4.677 -0.14
/ avg req/sec 518.9 534.48 +15.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.248 2.213 -0.04
/error-in-render avg req/sec 1112.1 1129.62 +17.52
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js rsc/client-utils Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/client-utils Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js rsc/client-utils Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/client-utils Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/client-utils Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 7b27731

@huozhi huozhi marked this pull request as ready for review April 13, 2022 22:13
@kodiakhq kodiakhq bot merged commit f74b59c into vercel:canary Apr 13, 2022
@huozhi huozhi deleted the rsc/client-utils branch April 13, 2022 23:15
kodiakhq bot pushed a commit that referenced this pull request Apr 13, 2022
Follow up of #36135 

Add `next/head` as client component
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants