Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix req.url of rsc dynamic routes pages gSSP in edge runtime #36134

Merged
merged 1 commit into from Apr 13, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 13, 2022

We were feeding pathname like /routes/[dynamic] as req.url to RSC pages in edge runtime, which is not aligned with node runtime

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 13, 2022
@huozhi huozhi marked this pull request as ready for review April 13, 2022 21:20
@ijjk
Copy link
Member

ijjk commented Apr 13, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
buildDuration 16.1s 16s -122ms
buildDurationCached 6.4s 6.4s ⚠️ +3ms
nodeModulesSize 484 MB 484 MB ⚠️ +10 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
/ failed reqs 0 0
/ total time (seconds) 3.189 3.21 ⚠️ +0.02
/ avg req/sec 783.91 778.82 ⚠️ -5.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.397 1.377 -0.02
/error-in-render avg req/sec 1789.83 1815.24 +25.41
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
buildDuration 19s 19.1s ⚠️ +26ms
buildDurationCached 6.3s 6.3s ⚠️ +6ms
nodeModulesSize 484 MB 484 MB ⚠️ +10 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
/ failed reqs 0 0
/ total time (seconds) 3.213 3.255 ⚠️ +0.04
/ avg req/sec 778.07 768.14 ⚠️ -9.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.389 1.368 -0.02
/error-in-render avg req/sec 1799.67 1826.92 +27.25
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/fix-gssp-req-url Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: bcc2f4e

@kodiakhq kodiakhq bot merged commit 1e451ab into vercel:canary Apr 13, 2022
@huozhi huozhi deleted the rsc/fix-gssp-req-url branch April 26, 2022 18:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants