Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix only generated case in minimal mode #36130

Merged
merged 1 commit into from Apr 13, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 13, 2022

Follow-up to #36108 this fixes a case noticed during testing where we unexpectedly render the 404 in minimal mode since no cache is present in the serverless function but we always want to be sure to render in minimal mode.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk
Copy link
Member Author

ijjk commented Apr 13, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
buildDuration 16.5s 15.7s -777ms
buildDurationCached 6.2s 6.2s ⚠️ +47ms
nodeModulesSize 484 MB 484 MB ⚠️ +45 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
/ failed reqs 0 0
/ total time (seconds) 3.209 3.249 ⚠️ +0.04
/ avg req/sec 779.06 769.38 ⚠️ -9.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.384 1.381 0
/error-in-render avg req/sec 1806.74 1810.77 +4.03
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
buildDuration 18.9s 18.8s -91ms
buildDurationCached 6.2s 6.3s ⚠️ +104ms
nodeModulesSize 484 MB 484 MB ⚠️ +45 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
/ failed reqs 0 0
/ total time (seconds) 3.246 3.231 -0.02
/ avg req/sec 770.09 773.82 +3.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.355 1.346 -0.01
/error-in-render avg req/sec 1845.63 1856.88 +11.25
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/minimal-mode-only-generated Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 610e001

@ijjk ijjk merged commit d24eeb6 into vercel:canary Apr 13, 2022
@ijjk ijjk deleted the fix/minimal-mode-only-generated branch April 13, 2022 20:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants