Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): Update css parser #36114

Merged
merged 2 commits into from Apr 13, 2022
Merged

feat(next-swc): Update css parser #36114

merged 2 commits into from Apr 13, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 13, 2022

This only applies swc-project/swc@81370d1

This fixes parsing of legacy calcs.

@ijjk
Copy link
Member

ijjk commented Apr 13, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js swc-css-up Change
buildDuration 18.4s 17.7s -719ms
buildDurationCached 7.1s 6.6s -510ms
nodeModulesSize 484 MB 484 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-css-up Change
/ failed reqs 0 0
/ total time (seconds) 3.841 3.543 -0.3
/ avg req/sec 650.9 705.59 +54.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.57 1.551 -0.02
/error-in-render avg req/sec 1592.25 1611.55 +19.3
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-css-up Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-css-up Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-css-up Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-css-up Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-css-up Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-css-up Change
buildDuration 20s 20.8s ⚠️ +857ms
buildDurationCached 6.5s 7.4s ⚠️ +989ms
nodeModulesSize 484 MB 484 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-css-up Change
/ failed reqs 0 0
/ total time (seconds) 3.643 3.818 ⚠️ +0.18
/ avg req/sec 686.18 654.72 ⚠️ -31.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.517 1.548 ⚠️ +0.03
/error-in-render avg req/sec 1647.83 1614.77 ⚠️ -33.06
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-css-up Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-css-up Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-css-up Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-css-up Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-css-up Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 3386d04

@kodiakhq kodiakhq bot merged commit 4bf01d4 into vercel:canary Apr 13, 2022
@kdy1 kdy1 deleted the swc-css-up branch April 18, 2022 12:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants