Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental onlyGenereated flag for unstable_revalidate #36108

Merged
merged 5 commits into from Apr 13, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 12, 2022

This adds experimental support for only manually revalidating if a page has been generated and is in the cache e.g. skipping revalidating pages that have yet to be generated with fallback: true.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 12, 2022
@ijjk
Copy link
Member Author

ijjk commented Apr 12, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
buildDuration 19.5s 19.4s -142ms
buildDurationCached 7.5s 7.4s -73ms
nodeModulesSize 484 MB 484 MB ⚠️ +2.24 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
/ failed reqs 0 0
/ total time (seconds) 3.944 4.048 ⚠️ +0.1
/ avg req/sec 633.83 617.57 ⚠️ -16.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.707 1.703 0
/error-in-render avg req/sec 1464.88 1468.08 +3.2
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
buildDuration 22.5s 22.2s -359ms
buildDurationCached 7.3s 7.4s ⚠️ +101ms
nodeModulesSize 484 MB 484 MB ⚠️ +2.24 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
/ failed reqs 0 0
/ total time (seconds) 3.984 3.881 -0.1
/ avg req/sec 627.55 644.24 +16.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.692 1.726 ⚠️ +0.03
/error-in-render avg req/sec 1477.29 1448.32 ⚠️ -28.97
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js feat/revalidate-if-generated Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: d62d9e6

@ijjk ijjk marked this pull request as ready for review April 13, 2022 00:17
@ijjk ijjk requested a review from styfle April 13, 2022 15:37
test/e2e/prerender.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing ifGenerated to onlyGenerated?

@ijjk ijjk changed the title Add experimental ifGenereated flag for unstable_revalidate Add experimental onlyGenereated flag for unstable_revalidate Apr 13, 2022
@ijjk ijjk requested a review from styfle April 13, 2022 16:05
@ijjk ijjk requested a review from styfle April 13, 2022 16:25
@ijjk ijjk merged commit 74dead2 into vercel:canary Apr 13, 2022
@ijjk ijjk deleted the feat/revalidate-if-generated branch April 13, 2022 16:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants