Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example] Fix fast refresh in with-slate example #36095

Merged
merged 4 commits into from Apr 12, 2022
Merged

[example] Fix fast refresh in with-slate example #36095

merged 4 commits into from Apr 12, 2022

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Apr 12, 2022 •
edited

This PR fixes #29740 and updates the with-slate example to match slates latest version.

more info

Bug

  • Related issues linked using fixes #number

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Apr 12, 2022
@HaNdTriX HaNdTriX changed the title [examples] Fix with slate example [example] Fix with-slate FastRefresh Apr 12, 2022
@HaNdTriX HaNdTriX changed the title [example] Fix with-slate FastRefresh [example] Fix fast refresh in with-slate example Apr 12, 2022
ijjk
ijjk approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 7013a8c into vercel:canary Apr 12, 2022
@HaNdTriX HaNdTriX deleted the examples/with-slate branch April 12, 2022 18:09
@snyk-bot snyk-bot mentioned this pull request May 4, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with-slate: Unhandled Runtime Error Error: Cannot find a descendant at path [0] in node
2 participants
@HaNdTriX @ijjk