Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export from and native modules in server component #36072

Merged
merged 9 commits into from Apr 13, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Apr 11, 2022

This PR fixes a bunch of bugs and it now supports:

  • Importing a client component from a nested server component (a.server → b.server → c.client).
  • The export from syntax in server component (export { default } from './a.server')
  • Native modules in server components (currently broken)

Buga

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Apr 11, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/1562 Change
buildDuration 22.4s 22.6s ⚠️ +162ms
buildDurationCached 8.2s 8.2s ⚠️ +37ms
nodeModulesSize 484 MB 484 MB ⚠️ +2.38 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/1562 Change
/ failed reqs 0 0
/ total time (seconds) 4.922 4.906 -0.02
/ avg req/sec 507.92 509.61 +1.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.176 2.255 ⚠️ +0.08
/error-in-render avg req/sec 1148.69 1108.83 ⚠️ -39.86
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/1562 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/1562 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/1562 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/1562 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/1562 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/1562 Change
buildDuration 27s 26.4s -613ms
buildDurationCached 8.3s 8.3s ⚠️ +2ms
nodeModulesSize 484 MB 484 MB ⚠️ +2.38 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/1562 Change
/ failed reqs 0 0
/ total time (seconds) 4.833 4.729 -0.1
/ avg req/sec 517.26 528.65 +11.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.21 2.279 ⚠️ +0.07
/error-in-render avg req/sec 1131.38 1096.75 ⚠️ -34.63
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/1562 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/1562 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/1562 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.77 kB 5.77 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/1562 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/1562 Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 99b64ae

huozhi
huozhi previously approved these changes Apr 12, 2022
@kodiakhq kodiakhq bot merged commit 19b625e into vercel:canary Apr 13, 2022
@shuding shuding deleted the shu/1562 branch April 13, 2022 11:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants