Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outputStandalone with optimizeCss #36028

Merged
merged 3 commits into from Apr 11, 2022
Merged

Fix outputStandalone with optimizeCss #36028

merged 3 commits into from Apr 11, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 9, 2022

This fixes copying CSS files with optimizeCss: true enabled along with outputStandalone as we were previously attempting to copy without creating the nested directory.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #35708

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 9, 2022
@ijjk ijjk marked this pull request as ready for review April 9, 2022 01:08
@ijjk
Copy link
Member Author

ijjk commented Apr 9, 2022 •
edited

Stats from current PR

Commit: c4d1d22

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
buildDuration 15.7s 15.5s -127ms
buildDurationCached 6.1s 6s -46ms
nodeModulesSize 484 MB 484 MB ⚠️ +334 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.222 3.137 -0.08
/ avg req/sec 775.88 796.82 +20.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.363 1.277 -0.09
/error-in-render avg req/sec 1833.86 1957.9 +124.04
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.7 kB 71.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.05 kB 3.05 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.68 kB 5.68 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.32 kB 2.32 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 15.9 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
buildDuration 18.3s 18.2s -92ms
buildDurationCached 5.8s 6s ⚠️ +223ms
nodeModulesSize 484 MB 484 MB ⚠️ +334 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.22 3.235 ⚠️ +0.01
/ avg req/sec 776.3 772.86 ⚠️ -3.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.312 1.383 ⚠️ +0.07
/error-in-render avg req/sec 1905.91 1808.27 ⚠️ -97.64
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.3 kB 28.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.3 kB 72.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 325 B 325 B ✓
dynamic-HASH.js gzip 3.03 kB 3.03 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.74 kB 5.74 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.38 kB 2.38 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: c4d1d22

@ijjk
Copy link
Member Author

ijjk commented Apr 9, 2022 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
buildDuration 15.7s 15.5s -127ms
buildDurationCached 6.1s 6s -46ms
nodeModulesSize 484 MB 484 MB ⚠️ +334 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.222 3.137 -0.08
/ avg req/sec 775.88 796.82 +20.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.363 1.277 -0.09
/error-in-render avg req/sec 1833.86 1957.9 +124.04
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.7 kB 71.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.05 kB 3.05 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.68 kB 5.68 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.32 kB 2.32 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 15.9 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
buildDuration 18.3s 18.2s -92ms
buildDurationCached 5.8s 6s ⚠️ +223ms
nodeModulesSize 484 MB 484 MB ⚠️ +334 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.22 3.235 ⚠️ +0.01
/ avg req/sec 776.3 772.86 ⚠️ -3.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.312 1.383 ⚠️ +0.07
/error-in-render avg req/sec 1905.91 1808.27 ⚠️ -97.64
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.3 kB 28.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.3 kB 72.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 325 B 325 B ✓
dynamic-HASH.js gzip 3.03 kB 3.03 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.74 kB 5.74 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.38 kB 2.38 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/standalone-optimizecss Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: c4d1d22

@tvelingkar

This comment was marked as off-topic.

Sign in to view
@ijjk ijjk merged commit 95a8f31 into vercel:canary Apr 11, 2022
@ijjk ijjk deleted the fix/standalone-optimizecss branch April 11, 2022 21:14
@snyk-bot snyk-bot mentioned this pull request May 4, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File copy error when building with outputStandalone + optimizeCss
2 participants
@ijjk @tvelingkar