Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use renderToString for flush effects #35999

Merged
merged 2 commits into from Apr 8, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 8, 2022

Use render to string call to render flush effects instead of rendering with stream plus converting to string

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 8, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review April 8, 2022 11:19
@huozhi huozhi marked this pull request as draft April 8, 2022 11:48
@huozhi huozhi marked this pull request as ready for review April 8, 2022 12:31
@ijjk
Copy link
Member

ijjk commented Apr 8, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
buildDuration 15.4s 15.6s ⚠️ +148ms
buildDurationCached 6.1s 6s -181ms
nodeModulesSize 478 MB 478 MB -508 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
/ failed reqs 0 0
/ total time (seconds) 3.214 3.15 -0.06
/ avg req/sec 777.8 793.69 +15.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.353 1.337 -0.02
/error-in-render avg req/sec 1847.5 1869.29 +21.79
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.64 kB 5.64 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
buildDuration 18.6s 18.9s ⚠️ +244ms
buildDurationCached 6.2s 6s -175ms
nodeModulesSize 478 MB 478 MB -508 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
/ failed reqs 0 0
/ total time (seconds) 3.273 3.663 ⚠️ +0.39
/ avg req/sec 763.74 682.51 ⚠️ -81.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.436 1.454 ⚠️ +0.02
/error-in-render avg req/sec 1740.52 1719.03 ⚠️ -21.49
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js simplify-flush-effects-call Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: f694e2e

@kodiakhq kodiakhq bot merged commit eddf171 into vercel:canary Apr 8, 2022
colinhacks pushed a commit to colinhacks/next.js that referenced this pull request Apr 14, 2022
Use render to string call to render flush effects instead of rendering with stream plus converting to string
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants