feat(next-swc): Update swc crates #35996

kdy1 · 2022-04-08T09:49:53Z

Note:

This PR is based on feat(next-swc): Split rust crates #35909

(If this PR is merged, I will close #35909)

This PR updates swc to swc-project/swc@6c50ae6

Closes swcMinify regression found in 12.1.1 onwards #35920

ijjk · 2022-04-08T10:51:27Z

Failing test suites

Commit: c0799e8

yarn testheadless test/development/acceptance/ReactRefreshLogBox.test.ts

ReactRefreshLogBox > syntax > runtime error

Expand output

● ReactRefreshLogBox › syntax > runtime error

expect(received).toMatchSnapshot()

Snapshot name: `ReactRefreshLogBox syntax > runtime error 2`

- Snapshot  - 3
+ Received  + 4

  ./index.js
  Error: 
-   x Unexpected eof
+   x Expected '}', got '<eof>'
     ,----
   8 | export default function FunctionNamed() {
-    :                                          ^
+    :                                         ^
     `----

  Caused by:
      0: failed to process input file
-     1: Syntax Error
+     1: error was recoverable, but proceeding would result in wrong codegen
+     2: Syntax Error

  455 |     await new Promise((resolve) => setTimeout(resolve, 1000))
  456 |     expect(await session.hasRedbox(true)).toBe(true)
> 457 |     expect(await session.getRedboxSource()).toMatchSnapshot()
      |                                             ^
  458 |
  459 |     // Test that runtime error does not take over:
  460 |     await new Promise((resolve) => setTimeout(resolve, 2000))

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox.test.ts:457:45)

● ReactRefreshLogBox › syntax > runtime error

expect(received).toMatchSnapshot()

Snapshot name: `ReactRefreshLogBox syntax > runtime error 3`

- Snapshot  - 3
+ Received  + 4

  ./index.js
  Error: 
-   x Unexpected eof
+   x Expected '}', got '<eof>'
     ,----
   8 | export default function FunctionNamed() {
-    :                                          ^
+    :                                         ^
     `----

  Caused by:
      0: failed to process input file
-     1: Syntax Error
+     1: error was recoverable, but proceeding would result in wrong codegen
+     2: Syntax Error

  460 |     await new Promise((resolve) => setTimeout(resolve, 2000))
  461 |     expect(await session.hasRedbox(true)).toBe(true)
> 462 |     expect(await session.getRedboxSource()).toMatchSnapshot()
      |                                             ^
  463 |
  464 |     await cleanup()
  465 |   })

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox.test.ts:462:45)

Read more about building and testing Next.js in contributing.md.

Brooooooklyn

wasm build failed because of mimalloc

kdy1 · 2022-04-10T06:51:29Z

@Brooooooklyn Thanks and I fixed it

ijjk · 2022-04-10T07:01:40Z

Stats from current PR

Default Build (Decrease detected ✓)

General

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
buildDuration	15.2s	15.1s	-100ms
buildDurationCached	6s	6s	⚠️ +2ms
nodeModulesSize	484 MB	484 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3	3.007	⚠️ +0.01
/ avg req/sec	833.24	831.44	⚠️ -1.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.156	1.17	⚠️ +0.01
/error-in-render avg req/sec	2162.83	2136.85	⚠️ -25.98

Client Bundles (main, webpack)

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.7 kB	71.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	192 B	192 B	✓
amp-HASH.js gzip	309 B	309 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	3.05 kB	3.05 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.68 kB	5.68 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.32 kB	2.32 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.9 kB	15.9 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	524 B	524 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
buildDuration	18.2s	17.9s	-265ms
buildDurationCached	6s	5.9s	-9ms
nodeModulesSize	484 MB	484 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.005	3.016	⚠️ +0.01
/ avg req/sec	832.04	829	⚠️ -3.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.172	1.133	-0.04
/error-in-render avg req/sec	2132.56	2206.03	+73.47

Client Bundles (main, webpack)

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.3 kB	28.3 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	313 B	313 B	✓
css-HASH.js gzip	325 B	325 B	✓
dynamic-HASH.js gzip	3.03 kB	3.03 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.74 kB	5.74 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.38 kB	2.38 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	388 B	388 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16 kB	16 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js swc-plugins	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 261b1a8

kdy1 added 21 commits April 5, 2022 23:39

Move

01ba24d

Adjust

9dfdcf3

publish = false

cc43256

Tree

77c7414

Move tests

a2e2e89

fixup

e03941b

Split emotion

2a29506

Split styled_jsx

4ae4244

Split styled_jsx

ff56979

fmt

9717a1b

--fix

3d755e8

clippy

3f9cd6e

Update crates

40dfc2e

fixup

bda9eb6

publish

9240889

Bump

ae25949

Rename

4be21b8

authors

c2a5b2e

Update

b97b6ce

More update

5f7b7bd

Oh

bb1a0ce

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 8, 2022

kdy1 marked this pull request as ready for review April 8, 2022 09:49

kdy1 requested review from timneutkens, ijjk, shuding and huozhi as code owners April 8, 2022 09:50

Update test refs

1241b24

This comment has been minimized.

Sign in to view

Merge branch 'canary' into swc-plugins

c0799e8

This comment has been minimized.

Sign in to view

Update test refs

770e183

This comment has been minimized.

Sign in to view

huozhi requested review from Brooooooklyn and padmaia April 8, 2022 11:38

Update again

2d6cd07

This comment has been minimized.

Sign in to view

Brooooooklyn reviewed Apr 10, 2022

View reviewed changes

Fix

261b1a8

Brooooooklyn approved these changes Apr 10, 2022

View reviewed changes

balazsorban44 merged commit 16f7084 into vercel:canary Apr 11, 2022

kdy1 deleted the swc-plugins branch April 11, 2022 10:00

snyk-bot mentioned this pull request May 4, 2022

[Snyk] Upgrade next from 12.0.7 to 12.1.5 NOUIY/next.js#230

Open

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(next-swc): Update swc crates #35996

feat(next-swc): Update swc crates #35996

kdy1 commented Apr 8, 2022 •

edited

This comment has been minimized.

ijjk commented Apr 8, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Brooooooklyn left a comment

kdy1 commented Apr 10, 2022

ijjk commented Apr 10, 2022

feat(next-swc): Update swc crates #35996

feat(next-swc): Update swc crates #35996

Conversation

kdy1 commented Apr 8, 2022 • edited

This comment has been minimized.

ijjk commented Apr 8, 2022

Failing test suites

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Brooooooklyn left a comment

Choose a reason for hiding this comment

kdy1 commented Apr 10, 2022

ijjk commented Apr 10, 2022

Stats from current PR

kdy1 commented Apr 8, 2022 •

edited