Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shared component with next built-in client components #35975

Merged
merged 8 commits into from Apr 7, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 7, 2022

Fixes #35449

Include the shared components (from source code) is in client bundles, previously we lost them so that the client components imported by them are lost in module graph

  • let flight server loader apply to all pages and imported modules (except node_modules at the moment)
  • if it's a shared component from source code, include it in client bundle
  • ignore handling node_modules at the moment (due to the limitation support of esm imports with RSC)

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 7, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review April 7, 2022 17:46
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Apr 7, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js shared-component Change
buildDuration 15.1s 14.9s -183ms
buildDurationCached 6.1s 5.9s -151ms
nodeModulesSize 477 MB 477 MB ⚠️ +1.86 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js shared-component Change
/ failed reqs 0 0
/ total time (seconds) 3.011 2.99 -0.02
/ avg req/sec 830.31 836.17 +5.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.183 1.154 -0.03
/error-in-render avg req/sec 2113.19 2167.1 +53.91
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js shared-component Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js shared-component Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js shared-component Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.64 kB 5.64 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js shared-component Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js shared-component Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js shared-component Change
buildDuration 17.8s 17.6s -198ms
buildDurationCached 5.9s 6s ⚠️ +8ms
nodeModulesSize 477 MB 477 MB ⚠️ +1.86 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js shared-component Change
/ failed reqs 0 0
/ total time (seconds) 2.997 2.983 -0.01
/ avg req/sec 834.12 838.12 +4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.112 1.147 ⚠️ +0.03
/error-in-render avg req/sec 2248.85 2179.15 ⚠️ -69.7
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js shared-component Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js shared-component Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js shared-component Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js shared-component Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js shared-component Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 4e12d56

@kodiakhq kodiakhq bot merged commit 630bf80 into vercel:canary Apr 7, 2022
@shuding shuding deleted the shared-component branch April 8, 2022 10:19
colinhacks pushed a commit to colinhacks/next.js that referenced this pull request Apr 14, 2022
…#35975)

Fixes vercel#35449

Include the shared components (from source code) is in client bundles, previously we lost them so that the client components imported by them are lost in module graph

* let flight server loader apply to all pages and imported modules (except node_modules at the moment)
* if it's a shared component from source code, include it in client bundle
* ignore handling node_modules at the moment (due to the limitation support of esm imports with RSC)

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [x] Errors have helpful link attached, see `contributing.md`
kodiakhq bot pushed a commit that referenced this pull request Apr 17, 2022
x-ref: vercel/server-components-notes-demo#17

Previously in #35975 we ignore handling node_modules as a workaround for 3rd party packages, but for next buildin components we should still handle them for processing client components
SukkaW pushed a commit to SukkaW/next.js that referenced this pull request Apr 18, 2022
x-ref: vercel/server-components-notes-demo#17

Previously in vercel#35975 we ignore handling node_modules as a workaround for 3rd party packages, but for next buildin components we should still handle them for processing client components
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSC: shared components using next built-in components doesn't work
3 participants