Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emotion SWC Plugin - Allow for jsxImportSource to be configurable #35963

Merged
merged 5 commits into from Apr 7, 2022
Merged

Emotion SWC Plugin - Allow for jsxImportSource to be configurable #35963

merged 5 commits into from Apr 7, 2022

Conversation

JohnDaly
Copy link
Contributor

@JohnDaly JohnDaly commented Apr 7, 2022

Allowing the jsxImportSource to be configurable when using the Emotion SWC plugin

Bug

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the type: next label Apr 7, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Apr 7, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
buildDuration 15.5s 15.5s ⚠️ +12ms
buildDurationCached 6s 6.1s ⚠️ +27ms
nodeModulesSize 477 MB 477 MB ⚠️ +114 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.047 3.054 ⚠️ +0.01
/ avg req/sec 820.41 818.55 ⚠️ -1.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.33 1.334 0
/error-in-render avg req/sec 1880.14 1874.22 ⚠️ -5.92
Client Bundles (main, webpack)
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.7 kB 71.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.05 kB 3.05 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.64 kB 5.64 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.32 kB 2.32 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 15.9 kB ✓
Client Build Manifests
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
index.html gzip 530 B 530 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
buildDuration 18.1s 18.6s ⚠️ +495ms
buildDurationCached 6s 6.2s ⚠️ +186ms
nodeModulesSize 477 MB 477 MB ⚠️ +114 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.044 3.106 ⚠️ +0.06
/ avg req/sec 821.36 804.76 ⚠️ -16.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.338 1.342 0
/error-in-render avg req/sec 1868.96 1862.79 ⚠️ -6.17
Client Bundles (main, webpack)
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.3 kB 28.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 325 B 325 B ✓
dynamic-HASH.js gzip 3.03 kB 3.03 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.7 kB 5.7 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.38 kB 2.38 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 15.9 kB ✓
Client Build Manifests
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary JohnDaly/next.js fix/emotion-swc-jsx-import-source Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 21cff5a

@balazsorban44 balazsorban44 merged commit 9110b5a into vercel:canary Apr 7, 2022
@JohnDaly JohnDaly deleted the fix/emotion-swc-jsx-import-source branch April 7, 2022 15:09
colinhacks pushed a commit to colinhacks/next.js that referenced this pull request Apr 14, 2022
@JohnDaly @balazsorban44 @colinhacks
Emotion SWC Plugin - Allow for jsxImportSource to be configurable (ve…
8644056 
…rcel#35963)

* Allowing the jsxImportSource to be configurable when using the Emotion SWC plugin

* Adding test case

* Addressing PR feedback

* Moving getEmotionOptions call back to where it was previously

Co-authored-by: Balázs Orbán <info@balazsorban.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JohnDaly @ijjk @Brooooooklyn @balazsorban44