Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure minimalMode previousCache expire time is capped #35954

Merged
merged 3 commits into from Apr 7, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 7, 2022

This is a follow-up to #34935 which ensures we don't consider the full revalidation time for how long the previous cache item should be leveraged since a long expire time can prevent on-demand revalidations from being able to update the cache before the revalidate period has ended.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: #34935

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 7, 2022
@ijjk ijjk marked this pull request as ready for review April 7, 2022 00:47
@ijjk ijjk requested a review from Timer April 7, 2022 00:48
@ijjk

This comment has been minimized.

@ijjk ijjk requested a review from styfle April 7, 2022 14:51
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Apr 7, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
buildDuration 18.8s 18.7s -152ms
buildDurationCached 7.4s 7.3s -58ms
nodeModulesSize 477 MB 477 MB -290 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
/ failed reqs 0 0
/ total time (seconds) 3.811 3.861 ⚠️ +0.05
/ avg req/sec 655.98 647.58 ⚠️ -8.4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.694 1.575 -0.12
/error-in-render avg req/sec 1476.06 1587.35 +111.29
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.64 kB 5.64 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
buildDuration 21.3s 21.7s ⚠️ +414ms
buildDurationCached 7.5s 7.2s -292ms
nodeModulesSize 477 MB 477 MB -290 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
/ failed reqs 0 0
/ total time (seconds) 3.881 3.94 ⚠️ +0.06
/ avg req/sec 644.2 634.56 ⚠️ -9.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.649 1.672 ⚠️ +0.02
/error-in-render avg req/sec 1516.45 1494.99 ⚠️ -21.46
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/isr-minimal-cache Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 41a10c6

@ijjk ijjk merged commit 26aacb0 into vercel:canary Apr 7, 2022
@ijjk ijjk deleted the fix/isr-minimal-cache branch April 7, 2022 16:32
colinhacks pushed a commit to colinhacks/next.js that referenced this pull request Apr 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants