Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #35937

Merged
merged 5 commits into from Apr 6, 2022
Merged

Code refactoring #35937

merged 5 commits into from Apr 6, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Apr 6, 2022

Clean up some code in the renderer and make it more readable.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 6, 2022
@ijjk

This comment was marked as resolved.

@shuding shuding marked this pull request as ready for review April 6, 2022 15:08
@ijjk
Copy link
Member

ijjk commented Apr 6, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/5ce3 Change
buildDuration 16.9s 17s ⚠️ +130ms
buildDurationCached 6.8s 6.5s -226ms
nodeModulesSize 477 MB 477 MB -1.03 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/5ce3 Change
/ failed reqs 0 0
/ total time (seconds) 3.525 3.522 0
/ avg req/sec 709.24 709.79 +0.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.48 1.481 0
/error-in-render avg req/sec 1688.92 1687.51 ⚠️ -1.41
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/5ce3 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/5ce3 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/5ce3 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.64 kB 5.64 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/5ce3 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/5ce3 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/5ce3 Change
buildDuration 19.1s 20s ⚠️ +913ms
buildDurationCached 6.5s 6.4s -152ms
nodeModulesSize 477 MB 477 MB -1.03 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/5ce3 Change
/ failed reqs 0 0
/ total time (seconds) 3.328 3.402 ⚠️ +0.07
/ avg req/sec 751.26 734.81 ⚠️ -16.45
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.425 1.502 ⚠️ +0.08
/error-in-render avg req/sec 1753.96 1664.6 ⚠️ -89.36
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/5ce3 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/5ce3 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/5ce3 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/5ce3 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/5ce3 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: da052be

@kodiakhq kodiakhq bot merged commit d0bf3ee into vercel:canary Apr 6, 2022
@shuding shuding deleted the shu/5ce3 branch April 6, 2022 16:31
colinhacks pushed a commit to colinhacks/next.js that referenced this pull request Apr 14, 2022
Clean up some code in the renderer and make it more readable.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants