Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo to use react 18 by default #35888

Merged
merged 6 commits into from Apr 5, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 4, 2022

This updates our yarn next command to leverage react v18 by default and removes the need for the test require hook/config modifying when testing react 18. There are some fixtures we need to investigate react 18 support in follow-ups:

  • test/integration/client-navigation-a11y
  • test/integration/critical-css
  • test/integration/custom-error-page-exception
  • test/integration/font-optimization
  • AMP specific tests

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 4, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk ijjk added the type: next label Apr 5, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment was marked as outdated.

@ijjk ijjk marked this pull request as ready for review April 5, 2022 17:04
@ijjk ijjk requested a review from styfle April 5, 2022 17:04
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Apr 5, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/default-react Change
buildDuration 15.2s 15.3s ⚠️ +108ms
buildDurationCached 6s 6s -48ms
nodeModulesSize 477 MB 477 MB ⚠️ +55 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/default-react Change
/ failed reqs 0 0
/ total time (seconds) 2.977 2.96 -0.02
/ avg req/sec 839.84 844.72 +4.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.21 1.219 ⚠️ +0.01
/error-in-render avg req/sec 2066.06 2050.74 ⚠️ -15.32
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/default-react Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/default-react Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/default-react Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.52 kB 5.52 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/default-react Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/default-react Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/default-react Change
buildDuration 18s 17.9s -107ms
buildDurationCached 6.1s 6.2s ⚠️ +56ms
nodeModulesSize 477 MB 477 MB ⚠️ +55 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/default-react Change
/ failed reqs 0 0
/ total time (seconds) 2.968 2.942 -0.03
/ avg req/sec 842.25 849.68 +7.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.222 1.208 -0.01
/error-in-render avg req/sec 2045.4 2069.91 +24.51
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/default-react Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/default-react Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/default-react Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.63 kB 5.63 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/default-react Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/default-react Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 3c9b81a

@kodiakhq kodiakhq bot merged commit 4a7ab34 into vercel:canary Apr 5, 2022
@ijjk ijjk deleted the update/default-react branch April 5, 2022 21:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants