Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webpack #35867

Merged
merged 3 commits into from Apr 7, 2022
Merged

update webpack #35867

merged 3 commits into from Apr 7, 2022

Conversation

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 4, 2022
@vercel vercel bot temporarily deployed to Preview April 4, 2022 09:28 Inactive
@ijjk

This comment has been minimized.

@matamatanot
Copy link
Contributor

#35864

@SukkaW
Copy link
Contributor

SukkaW commented Apr 4, 2022

#35864

My PR should probably be superseded by this one, because:

  1. @sokra is not only a member of the Next.js core team but also a maintainer of the Webpack.
  2. This PR also introduces changes to HMR (which is related to the webpack upgrade).
  3. Removal of optional chaining transpilation can be done in a separate PR.

@sokra
Copy link
Member Author

sokra commented Apr 5, 2022

Oh sorry I wasn't aware that there is already a PR for that.

This PR also introduces changes to HMR (which is related to the webpack upgrade).

Actually it's only the webpack update, without any additional changes.

The changes in this PR are only caused by the precompilation step in next.js

@ijjk

This comment has been minimized.

@sokra sokra marked this pull request as ready for review April 7, 2022 12:47
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Apr 7, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 21s 20.9s -99ms
buildDurationCached 7.9s 8s ⚠️ +79ms
nodeModulesSize 477 MB 477 MB ⚠️ +45 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0
/ total time (seconds) 4.574 4.542 -0.03
/ avg req/sec 546.52 550.37 +3.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.331 2.282 -0.05
/error-in-render avg req/sec 1072.48 1095.45 +22.97
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js webpack/update Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.64 kB 5.64 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 24.8s 25.1s ⚠️ +340ms
buildDurationCached 8.3s 8s -262ms
nodeModulesSize 477 MB 477 MB ⚠️ +45 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0
/ total time (seconds) 4.547 4.641 ⚠️ +0.09
/ avg req/sec 549.82 538.66 ⚠️ -11.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.255 2.273 ⚠️ +0.02
/error-in-render avg req/sec 1108.49 1099.72 ⚠️ -8.77
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js webpack/update Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: f77b15e

@kodiakhq kodiakhq bot merged commit 0164ac6 into canary Apr 7, 2022
@kodiakhq kodiakhq bot deleted the webpack/update branch April 7, 2022 16:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants