Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vitest example. #35858

Merged
merged 5 commits into from Apr 4, 2022
Merged

Add Vitest example. #35858

merged 5 commits into from Apr 4, 2022

Conversation

leerob
Copy link
Member

@leerob leerob commented Apr 3, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added area: documentation examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team labels Apr 3, 2022
@leerob @ijjk
Update examples/with-vitest/next.config.js
ce97dc8 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@kodiakhq kodiakhq bot merged commit 686a0f5 into canary Apr 4, 2022
@kodiakhq kodiakhq bot deleted the with-vitest branch April 4, 2022 18:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leerob @ijjk