Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReadableStream in client hydration for Firefox compatibility #35796

Merged
merged 4 commits into from Mar 31, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 31, 2022

Firefox doesn't support TransformStream but ReadableStream at the moment, change the implmentation of hydration to make firefox work with RSC

Bug

Fixes #35763
x-ref: vercel/next-react-server-components#38

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 31, 2022
@huozhi huozhi marked this pull request as ready for review March 31, 2022 21:01
@ijjk

This comment has been minimized.

@huozhi huozhi requested a review from ijjk March 31, 2022 21:02
@ijjk
Copy link
Member

ijjk commented Mar 31, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
buildDuration 15.6s 15.6s ⚠️ +15ms
buildDurationCached 6.2s 6.2s -19ms
nodeModulesSize 477 MB 477 MB -5 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
/ failed reqs 0 0
/ total time (seconds) 3.212 3.202 -0.01
/ avg req/sec 778.42 780.8 +2.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.406 1.394 -0.01
/error-in-render avg req/sec 1778.25 1793.77 +15.52
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
buildDuration 18.4s 18.6s ⚠️ +160ms
buildDurationCached 6.1s 6.2s ⚠️ +105ms
nodeModulesSize 477 MB 477 MB -5 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
/ failed reqs 0 0
/ total time (seconds) 3.194 3.19 0
/ avg req/sec 782.75 783.78 +1.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.405 1.411 ⚠️ +0.01
/error-in-render avg req/sec 1779.96 1772.02 ⚠️ -7.94
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js firefox-transform-stream Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 5b74809

@kodiakhq kodiakhq bot merged commit d165836 into vercel:canary Mar 31, 2022
@huozhi huozhi deleted the firefox-transform-stream branch March 31, 2022 21:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: TransformStream is not defined when running Server Components in Firefox
2 participants