Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Script] Use __non_webpack_require__ to fetch partytown server-side #35793

Merged
merged 1 commit into from Mar 31, 2022
Merged

[Script] Use __non_webpack_require__ to fetch partytown server-side #35793

merged 1 commit into from Mar 31, 2022

Conversation

housseindjirdeh
Copy link
Collaborator

A few errors about Next.js not correctly handling the missing partytown dependency in _document.js have been flagged. Instead of /* webpackIgnore: true */, this PR switches to use __non_webpack_require__ to ensure webpack doesn't process fetching the dep server-side.


Related issues:

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Mar 31, 2022
console.warn(
`Warning: Partytown could not be instantiated in your application due to an error. ${err}`
)
if (isError(err) && err.code !== 'MODULE_NOT_FOUND') {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijjk We already throw an error if the package is missing. Was a little noisy showing additional error messages hence why I included this condition.

@ijjk
Copy link
Member

ijjk commented Mar 31, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
buildDuration 15.6s 15.5s -21ms
buildDurationCached 6.2s 6.1s -103ms
nodeModulesSize 477 MB 477 MB ⚠️ +90 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
/ failed reqs 0 0
/ total time (seconds) 2.983 2.994 ⚠️ +0.01
/ avg req/sec 838.22 834.91 ⚠️ -3.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.229 1.252 ⚠️ +0.02
/error-in-render avg req/sec 2033.5 1996.41 ⚠️ -37.09
Client Bundles (main, webpack)
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
buildDuration 18s 18.1s ⚠️ +78ms
buildDurationCached 6.3s 6.1s -198ms
nodeModulesSize 477 MB 477 MB ⚠️ +90 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
/ failed reqs 0 0
/ total time (seconds) 2.943 3.016 ⚠️ +0.07
/ avg req/sec 849.61 828.85 ⚠️ -20.76
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.183 1.237 ⚠️ +0.05
/error-in-render avg req/sec 2112.63 2021.74 ⚠️ -90.89
Client Bundles (main, webpack)
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js update-partytown-require Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 3fb615c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants