Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue testing react v17 with e2e tests #35787

Merged
merged 11 commits into from Mar 31, 2022
Merged

Continue testing react v17 with e2e tests #35787

merged 11 commits into from Mar 31, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 31, 2022

Follow-up to #35774 this continues testing react v17 as well as react 18 in our e2e tests to ensure coverage since we have the concurrency to accommodate this.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Mar 31, 2022
@huozhi
Copy link
Member

huozhi commented Mar 31, 2022

looks like the only difference between 17 and 18 for should recover after a bad return from the render function is the stringified name of regex, it's either regex string itself, or the stringified of regex constructor..

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review March 31, 2022 17:54
huozhi
huozhi previously approved these changes Mar 31, 2022
View reviewed changes
@ijjk

This comment has been minimized.

Sign in to view
styfle
styfle reviewed Mar 31, 2022
View reviewed changes
test/lib/next-modes/base.ts Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Mar 31, 2022

Stats from current PR

Default Build
General
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
buildDuration 19.9s 20.1s ⚠️ +134ms
buildDurationCached 7.7s 7.9s ⚠️ +174ms
nodeModulesSize 477 MB 477 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.252 4.353 ⚠️ +0.1
/ avg req/sec 587.94 574.29 ⚠️ -13.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.198 2.164 -0.03
/error-in-render avg req/sec 1137.41 1155.02 +17.61
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.4 kB 28.4 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.05 kB 3.05 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.48 kB 5.48 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.7 kB 15.7 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for main-HASH.js 
@@ -1505,14 +1505,14 @@
           },
           [callbacks]
         );
-        if (false) {
-        }
         // We should ask to measure the Web Vitals after rendering completes so we
         // don't cause any hydration delay:
         _react.default.useEffect(function() {
           (0, _performanceRelayer).default(onPerfEntry);
           (0, _vitals).flushBufferedVitalsMetrics();
         }, []);
+        if (false) {
+        }
         return children;
       }
       // Dummy component that we render as a child of Root so that we can
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-444bd3ddf1f35edc.js"
+      src="/_next/static/chunks/main-ca8f6d6aba194701.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-444bd3ddf1f35edc.js"
+      src="/_next/static/chunks/main-ca8f6d6aba194701.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-444bd3ddf1f35edc.js"
+      src="/_next/static/chunks/main-ca8f6d6aba194701.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
buildDuration 23.8s 23.7s -116ms
buildDurationCached 7.8s 7.7s -135ms
nodeModulesSize 477 MB 477 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.343 4.313 -0.03
/ avg req/sec 575.66 579.67 +4.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.456 2.187 -0.27
/error-in-render avg req/sec 1018.06 1143.32 +125.26
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.8 kB 28.8 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.7 kB 72.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 325 B 325 B ✓
dynamic-HASH.js gzip 3.03 kB 3.03 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.59 kB 5.59 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.8 kB 15.8 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/e2e-test-react-17 Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for main-HASH.js 
@@ -1505,14 +1505,14 @@
           },
           [callbacks]
         );
-        if (false) {
-        }
         // We should ask to measure the Web Vitals after rendering completes so we
         // don't cause any hydration delay:
         _react.default.useEffect(function() {
           (0, _performanceRelayer).default(onPerfEntry);
           (0, _vitals).flushBufferedVitalsMetrics();
         }, []);
+        if (false) {
+        }
         return children;
       }
       // Dummy component that we render as a child of Root so that we can
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-444bd3ddf1f35edc.js"
+      src="/_next/static/chunks/main-ca8f6d6aba194701.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-444bd3ddf1f35edc.js"
+      src="/_next/static/chunks/main-ca8f6d6aba194701.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-444bd3ddf1f35edc.js"
+      src="/_next/static/chunks/main-ca8f6d6aba194701.js"
       defer=""
     ></script>
     <script
Commit: e22e734

styfle
styfle approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit e148d2b into vercel:canary Mar 31, 2022
@ijjk ijjk deleted the add/e2e-test-react-17 branch March 31, 2022 22:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi huozhi left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @huozhi @styfle