Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document styles with react 18 #35760

Merged
merged 2 commits into from Mar 31, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 30, 2022

This is a follow-up to #35736 that ensures we use the styles from _document.getInitialProps instead of only applying the styled-jsx styles.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #35758
x-ref: #35736

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 30, 2022
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review March 30, 2022 23:40
@ijjk
Copy link
Member Author

ijjk commented Mar 30, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
buildDuration 19.2s 19.3s ⚠️ +30ms
buildDurationCached 7.6s 7.4s -169ms
nodeModulesSize 477 MB 477 MB ⚠️ +409 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
/ failed reqs 0 0
/ total time (seconds) 4.129 4.165 ⚠️ +0.04
/ avg req/sec 605.48 600.25 ⚠️ -5.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.112 2.086 -0.03
/error-in-render avg req/sec 1183.83 1198.33 +14.5
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
buildDuration 22.8s 22.7s -121ms
buildDurationCached 7.4s 7.6s ⚠️ +196ms
nodeModulesSize 477 MB 477 MB ⚠️ +409 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
/ failed reqs 0 0
/ total time (seconds) 4.223 4.233 ⚠️ +0.01
/ avg req/sec 591.98 590.64 ⚠️ -1.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.138 2.105 -0.03
/error-in-render avg req/sec 1169.49 1187.81 +18.32
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/react-18-doc-styles Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 8daae43

@kodiakhq kodiakhq bot merged commit fe012ff into vercel:canary Mar 31, 2022
@ijjk ijjk deleted the fix/react-18-doc-styles branch March 31, 2022 00:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getInitialProps in _document does not produce server-side styled-components styles
2 participants