Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fix: Prevent page to scroll to top during data HMR) #35744

Merged
merged 4 commits into from Mar 30, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 30, 2022

This adds a test case for #35739 ensuring we don't regress on this. Opened as a separate PR as it seems changes from contributors was disabled on the original PR.

@ijjk
Copy link
Member Author

ijjk commented Mar 30, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js schickling-test/canary Change
buildDuration 20.4s 21.5s ⚠️ +1.1s
buildDurationCached 8s 8.3s ⚠️ +265ms
nodeModulesSize 467 MB 467 MB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js schickling-test/canary Change
/ failed reqs 0 0
/ total time (seconds) 4.38 4.403 ⚠️ +0.02
/ avg req/sec 570.79 567.77 ⚠️ -3.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.412 2.085 -0.33
/error-in-render avg req/sec 1036.28 1199.08 +162.8
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js schickling-test/canary Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js schickling-test/canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js schickling-test/canary Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js schickling-test/canary Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js schickling-test/canary Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js schickling-test/canary Change
buildDuration 25.4s 24.7s -644ms
buildDurationCached 8s 8.1s ⚠️ +111ms
nodeModulesSize 467 MB 467 MB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js schickling-test/canary Change
/ failed reqs 0 0
/ total time (seconds) 4.575 4.569 -0.01
/ avg req/sec 546.43 547.18 +0.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.287 2.263 -0.02
/error-in-render avg req/sec 1093.13 1104.77 +11.64
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js schickling-test/canary Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js schickling-test/canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js schickling-test/canary Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js schickling-test/canary Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js schickling-test/canary Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 8d28b81

@ijjk ijjk merged commit 050936c into canary Mar 30, 2022
@ijjk ijjk deleted the schickling-test/canary branch March 30, 2022 16:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants