Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update polyfill of web streams #35571

Merged
merged 16 commits into from Apr 7, 2022
Merged

Update polyfill of web streams #35571

merged 16 commits into from Apr 7, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 24, 2022 •
edited

This PR removes the TransformStream-based ReadableStream polyfill and directly use the full polyfill library for the sandbox.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 24, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment was marked as resolved.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@shuding shuding marked this pull request as ready for review April 7, 2022 13:48
@ijjk
Copy link
Member

ijjk commented Apr 7, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/dfbd Change
buildDuration 16.2s 15.9s -292ms
buildDurationCached 6.4s 5.8s -626ms
nodeModulesSize 477 MB 477 MB -11.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/dfbd Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.221 3.387 ⚠️ +0.17
/ avg req/sec 776.14 738.09 ⚠️ -38.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.373 1.517 ⚠️ +0.14
/error-in-render avg req/sec 1820.24 1647.79 ⚠️ -172.45
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/dfbd Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.7 kB 71.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/dfbd Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/dfbd Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.05 kB 3.05 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.64 kB 5.64 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.32 kB 2.32 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 15.9 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/dfbd Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/dfbd Change
index.html gzip 530 B 530 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/dfbd Change
buildDuration 16.9s 20.2s ⚠️ +3.4s
buildDurationCached 5.8s 5.8s -14ms
nodeModulesSize 477 MB 477 MB -11.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/dfbd Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.961 3.638 ⚠️ +0.68
/ avg req/sec 844.36 687.15 ⚠️ -157.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.299 1.543 ⚠️ +0.24
/error-in-render avg req/sec 1924.76 1620.08 ⚠️ -304.68
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/dfbd Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.3 kB 28.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/dfbd Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/dfbd Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 325 B 325 B ✓
dynamic-HASH.js gzip 3.03 kB 3.03 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.7 kB 5.7 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.38 kB 2.38 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 15.9 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/dfbd Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/dfbd Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 5b9e9aa

@shuding shuding merged commit 049bb22 into vercel:canary Apr 7, 2022
@shuding shuding deleted the shu/dfbd branch April 7, 2022 14:26
colinhacks pushed a commit to colinhacks/next.js that referenced this pull request Apr 14, 2022
@shuding @colinhacks
Update polyfill of web streams (vercel#35571)
66a9b05 
* attach pipeTo and pipeThrough polyfills to instance

* remove transformer polyfill

* remove polyfill

* fix missing polyfill in sandbox

* always polyfill the runtime

* always polyfill web streams in renderer

* fix missing AbortController and AbortSignal

* type fix

* fix type generation

* use global

Co-authored-by: Shu Ding <shu@shus-mac-studio.localdomain>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shuding @ijjk @huozhi