test: warn on substr() usage

[CommanderRoot]

Bug

substr() is deprecated and usage is removed by #35421

Feature

Warn via ESLint if someone wants to use substr()

Additional info

This should obviously not merged before #35421

[styfle]

Great, thanks! 🎉

[styfle]

Looks like we already got a PR in the last 3 days that used substr() 😆

Fixed in 9c2755c

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
buildDuration	15.9s	15.7s	-214ms
buildDurationCached	6.2s	6.1s	-29ms
nodeModulesSize	467 MB	467 MB	-2 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.154	3.155	0
/ avg req/sec	792.77	792.27	⚠️ -0.5
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.391	1.37	-0.02
/error-in-render avg req/sec	1797.47	1825.1	+27.63

Client Bundles (main, webpack)

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	192 B	192 B	✓
amp-HASH.js gzip	309 B	309 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.48 kB	5.48 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.2 kB	15.2 kB	✓

Client Build Manifests

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
buildDuration	19s	19.3s	⚠️ +246ms
buildDurationCached	6.2s	6.2s	-17ms
nodeModulesSize	467 MB	467 MB	-2 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.171	3.138	-0.03
/ avg req/sec	788.48	796.78	+8.3
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.396	1.376	-0.02
/error-in-render avg req/sec	1790.59	1817.16	+26.57

Client Bundles (main, webpack)

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	313 B	313 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.59 kB	5.59 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.33 kB	2.33 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	388 B	388 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.3 kB	15.3 kB	✓

Client Build Manifests

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	CommanderRoot/next.js lint/add-substr-restriction	Change
index.html gzip	531 B	531 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 9c2755c