Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect packages are used and eliminated in getServerSideProps #35404

Merged
merged 4 commits into from Apr 1, 2022

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Mar 17, 2022

Collect telemetry info about packages are used and eliminated in getServerSideProps

https://github.com/vercel/next-telemetry/pull/71

@ijjk

This comment has been minimized.

@ijjk ijjk added examples Issue/PR related to examples type: next labels Mar 22, 2022
@Brooooooklyn Brooooooklyn marked this pull request as ready for review March 22, 2022 13:25
@Brooooooklyn Brooooooklyn requested review from kdy1 and sokra March 22, 2022 13:26
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust codes look good to me

packages/next/build/webpack/loaders/next-swc-loader.js Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

kdy1
kdy1 previously approved these changes Mar 22, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

jescalan
jescalan previously approved these changes Mar 31, 2022
Copy link
Contributor

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! 👏

@ijjk

This comment has been minimized.

kdy1
kdy1 previously approved these changes Apr 1, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked rust code and it seems much better than using Rc<RefCell<T>> for the output type

@ijjk
Copy link
Member

ijjk commented Apr 1, 2022

Failing test suites

Commit: 9b8e95a

yarn testheadless test/e2e/i18n-api-support/index.test.ts

  • i18n API support > should fallback rewrite non-matching API request
Expand output

● i18n API support › should fallback rewrite non-matching API request

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 500

  65 |     for (const path of paths) {
  66 |       const res = await fetchViaHTTP(next.url, path)
> 67 |       expect(res.status).toBe(200)
     |                          ^
  68 |       expect(await res.text()).toContain('Example Domain')
  69 |     }
  70 |   })

  at Object.<anonymous> (e2e/i18n-api-support/index.test.ts:67:26)

Read more about building and testing Next.js in contributing.md.

@ijjk

This comment has been minimized.

@Brooooooklyn Brooooooklyn requested a review from ijjk April 1, 2022 08:36
@kodiakhq kodiakhq bot merged commit 8b9ae83 into canary Apr 1, 2022
@kodiakhq kodiakhq bot deleted the get-server-props-telemetry branch April 1, 2022 15:08
@ijjk
Copy link
Member

ijjk commented Apr 1, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
buildDuration 16.1s 15.9s -198ms
buildDurationCached 6.4s 6.3s -147ms
nodeModulesSize 477 MB 477 MB ⚠️ +3.64 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
/ failed reqs 0 0
/ total time (seconds) 3.237 3.201 -0.04
/ avg req/sec 772.22 780.97 +8.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.439 1.429 -0.01
/error-in-render avg req/sec 1737.67 1750 +12.33
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
buildDuration 17.8s 17.9s ⚠️ +88ms
buildDurationCached 5.8s 6s ⚠️ +153ms
nodeModulesSize 477 MB 477 MB ⚠️ +3.64 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
/ failed reqs 0 0
/ total time (seconds) 3.053 2.989 -0.06
/ avg req/sec 818.82 836.29 +17.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.421 1.313 -0.11
/error-in-render avg req/sec 1759.27 1903.44 +144.17
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js get-server-props-telemetry Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: ebbd4ae

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants