Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): Update swc crates #35395

Merged
merged 25 commits into from Mar 30, 2022
Merged

feat(next-swc): Update swc crates #35395

merged 25 commits into from Mar 30, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 17, 2022

Thir PR updates swc to swc-project/swc@a293adc

Fixes #35657

@@ -4,7 +4,7 @@ function NavigationItem({ active , className , }) {
active
}, className, "navigation-item") || "")}>

<_JSXStyle id={"2342aae4628612c6"}>{".navigation-item.jsx-2342aae4628612c6 a::after{content:attr(data-text);content:attr(data-text)/\"\"}"}</_JSXStyle>
<_JSXStyle id={"2342aae4628612c6"}>{'.navigation-item.jsx-2342aae4628612c6 a::after{content:attr(data-text);content:attr(data-text)/""}'}</_JSXStyle>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc now uses ' for string literal if " is used more times compared to '


x next/dynamic only accepts 2 arguments
,-[input.js:4:1]
4 | const DynamicComponentWithCustomLoading = dynamic(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default error emitter is changed

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as draft March 22, 2022 12:43
@kdy1
Copy link
Member Author

kdy1 commented Mar 22, 2022

I drafted this because I found an issue with this.
I'll undraft this after updating crates again

@kdy1 kdy1 marked this pull request as ready for review March 23, 2022 09:22
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as draft March 23, 2022 10:42
@kdy1 kdy1 marked this pull request as ready for review March 23, 2022 10:43
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 30, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-up-3 Change
buildDuration 15.4s 15.4s ⚠️ +38ms
buildDurationCached 5.8s 6s ⚠️ +183ms
nodeModulesSize 477 MB 477 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-3 Change
/ failed reqs 0 0
/ total time (seconds) 3.046 3.065 ⚠️ +0.02
/ avg req/sec 820.72 815.75 ⚠️ -4.97
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.374 1.391 ⚠️ +0.02
/error-in-render avg req/sec 1819.28 1796.69 ⚠️ -22.59
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-3 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-3 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-3 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-3 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-3 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js swc-up-3 Change
buildDuration 17.6s 17.7s ⚠️ +80ms
buildDurationCached 6s 5.8s -215ms
nodeModulesSize 477 MB 477 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-3 Change
/ failed reqs 0 0
/ total time (seconds) 3.023 3.02 0
/ avg req/sec 827.03 827.83 +0.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.37 1.346 -0.02
/error-in-render avg req/sec 1824.35 1857.43 +33.08
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-3 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-3 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-3 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-3 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-3 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 60d2521

@padmaia padmaia merged commit fdfa3c7 into vercel:canary Mar 30, 2022
@kdy1 kdy1 deleted the swc-up-3 branch March 30, 2022 22:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants