Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextResponse.json: pass options to Response #35367

Merged
merged 3 commits into from Apr 16, 2022
Merged

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Mar 16, 2022

In this way, it will be possible to customize status code or any other Response option, like:

NextResponse.json({ status: 'success' }, {  status: 201 })
NextResponse.json({ error: { code: 'bad_request' } }, { status: 400 })

@ijjk
Copy link
Member

ijjk commented Mar 22, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Kikobeats/next.js patch-1 Change
buildDuration 17.9s 18.5s ⚠️ +559ms
buildDurationCached 7s 7.4s ⚠️ +374ms
nodeModulesSize 485 MB 485 MB ⚠️ +275 B
Page Load Tests Overall increase ✓
vercel/next.js canary Kikobeats/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.737 3.744 ⚠️ +0.01
/ avg req/sec 669.05 667.72 ⚠️ -1.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.716 1.573 -0.14
/error-in-render avg req/sec 1456.76 1589.46 +132.7
Client Bundles (main, webpack)
vercel/next.js canary Kikobeats/next.js patch-1 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Kikobeats/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Kikobeats/next.js patch-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary Kikobeats/next.js patch-1 Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary Kikobeats/next.js patch-1 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Kikobeats/next.js patch-1 Change
buildDuration 20.8s 20.8s -40ms
buildDurationCached 7.1s 6.9s -199ms
nodeModulesSize 485 MB 485 MB ⚠️ +275 B
Page Load Tests Overall increase ✓
vercel/next.js canary Kikobeats/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.718 3.644 -0.07
/ avg req/sec 672.39 686.1 +13.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.591 1.563 -0.03
/error-in-render avg req/sec 1571.66 1599.67 +28.01
Client Bundles (main, webpack)
vercel/next.js canary Kikobeats/next.js patch-1 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Kikobeats/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Kikobeats/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary Kikobeats/next.js patch-1 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary Kikobeats/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 6858b09

@ijjk ijjk merged commit 8f8e497 into vercel:canary Apr 16, 2022
@Kikobeats Kikobeats deleted the patch-1 branch April 16, 2022 08:40
SukkaW pushed a commit to SukkaW/next.js that referenced this pull request Apr 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants