Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI command typo detection #34836

Merged
merged 5 commits into from Feb 26, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 26, 2022

This adds detecting CLI command typos when we fail to find a project directory.

screenshot Screen Shot 2022-02-25 at 4 21 37 PM

x-ref: #34830 (comment)

@ijjk

This comment has been minimized.

Co-authored-by: Steven <steven@ceriously.com>
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Feb 26, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
buildDuration 14s 13.7s -261ms
buildDurationCached 5.3s 5.5s ⚠️ +129ms
nodeModulesSize 368 MB 368 MB ⚠️ +4.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
/ failed reqs 0 0
/ total time (seconds) 2.84 2.664 -0.18
/ avg req/sec 880.43 938.53 +58.1
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.271 1.219 -0.05
/error-in-render avg req/sec 1966.98 2050.63 +83.65
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
buildDuration 16.5s 16.7s ⚠️ +212ms
buildDurationCached 5.3s 5.3s ⚠️ +17ms
nodeModulesSize 368 MB 368 MB ⚠️ +4.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
/ failed reqs 0 0
/ total time (seconds) 2.621 2.662 ⚠️ +0.04
/ avg req/sec 953.7 939.13 ⚠️ -14.57
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.206 1.207 0
/error-in-render avg req/sec 2073.11 2072.01 ⚠️ -1.1
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js feat/detect-command-typos Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 7bef308

@SukkaW
Copy link
Contributor

SukkaW commented Feb 26, 2022

@ijjk ijjk merged commit ed43c03 into vercel:canary Feb 26, 2022
@ijjk ijjk deleted the feat/detect-command-typos branch February 26, 2022 15:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants