Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure unstable_revalidate does not error from notFound: true #34826

Merged
merged 2 commits into from Feb 25, 2022
Merged

Ensure unstable_revalidate does not error from notFound: true #34826

merged 2 commits into from Feb 25, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 25, 2022

We are currently deriving a successful revalidation in unstable_revalidate from the response status although this can incorrectly signal a failed revalidation when returning notFound: true since the status will be 404 but it was successful. This updates to rely on the cache header instead which will be set to REVALIDATED when successfully revalidated.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #34809

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 25, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review February 25, 2022 21:02
@ijjk ijjk requested review from styfle and Timer February 25, 2022 21:02
@ijjk ijjk requested a review from styfle February 25, 2022 21:31
styfle
styfle approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member Author

ijjk commented Feb 25, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
buildDuration 19.3s 19.1s -281ms
buildDurationCached 7.6s 6.9s -648ms
nodeModulesSize 367 MB 367 MB ⚠️ +1.21 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.876 3.758 -0.12
/ avg req/sec 645 665.21 +20.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.099 1.992 -0.11
/error-in-render avg req/sec 1191.22 1255.19 +63.97
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.8 kB 27.8 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.5 kB 71.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
index.html gzip 530 B 530 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
buildDuration 22.3s 22.6s ⚠️ +256ms
buildDurationCached 7s 7.1s ⚠️ +92ms
nodeModulesSize 367 MB 367 MB ⚠️ +1.21 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.939 3.736 -0.2
/ avg req/sec 634.68 669.14 +34.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.16 2.032 -0.13
/error-in-render avg req/sec 1157.29 1230.16 +72.87
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.1 kB 42.1 kB ✓
main-HASH.js gzip 27.8 kB 27.8 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 5.08 kB 5.08 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.28 kB 2.28 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/on-demand-revalidate-notfound Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: b6c251f

@ijjk ijjk merged commit c947c93 into vercel:canary Feb 25, 2022
@ijjk ijjk deleted the fix/on-demand-revalidate-notfound branch February 25, 2022 22:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unstable_revalidate errors when returning notFound: true
2 participants
@ijjk @styfle