Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ncc dev overlay during build instead of pre-compile #34813

Merged
merged 2 commits into from Feb 25, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 25, 2022

This updates to prevent un-necessary updating of the compiled files when editing the dev-overlay package.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 25, 2022
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Feb 25, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
buildDuration 17s 17.3s ⚠️ +326ms
buildDurationCached 6.9s 6.6s -291ms
nodeModulesSize 367 MB 367 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
/ failed reqs 0 0
/ total time (seconds) 3.573 3.534 -0.04
/ avg req/sec 699.6 707.34 +7.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.787 1.829 ⚠️ +0.04
/error-in-render avg req/sec 1398.6 1366.5 ⚠️ -32.1
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
buildDuration 20.9s 20.9s ⚠️ +42ms
buildDurationCached 6.6s 6.6s
nodeModulesSize 367 MB 367 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
/ failed reqs 0 0
/ total time (seconds) 3.611 3.533 -0.08
/ avg req/sec 692.25 707.69 +15.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.853 1.895 ⚠️ +0.04
/error-in-render avg req/sec 1348.93 1318.97 ⚠️ -29.96
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/overlay-nccing Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: e4929b5

@ijjk ijjk marked this pull request as ready for review February 25, 2022 18:10
@ijjk ijjk requested a review from styfle February 25, 2022 18:29
@ijjk ijjk merged commit e6f14fa into vercel:canary Feb 25, 2022
@ijjk ijjk deleted the update/overlay-nccing branch February 25, 2022 19:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants