Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESlint error on build (even with starter template) #34798

Closed
1 task done
SebastianSava opened this issue Feb 25, 2022 · 8 comments
Closed
1 task done

ESlint error on build (even with starter template) #34798

SebastianSava opened this issue Feb 25, 2022 · 8 comments
Labels
bug Issue was opened via the bug report template.

Comments

@SebastianSava
Copy link

Verify canary release

  • I verified that the issue exists in Next.js canary release

Provide environment information

Operating System:        
  Platform: win32        
  Arch: x64
  Version: Windows 10 Pro
Binaries:
  Node: 16.13.1
  npm: 8.1.2
  Yarn: 1.22.15
  pnpm: 6.11.0
Relevant packages:
  next: 12.1.0
  react: 17.0.2
  react-dom: 17.0.2

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Describe the Bug

When i run npm run build

image

Expected Behavior

Build

To Reproduce

npm run build

@SebastianSava SebastianSava added the bug Issue was opened via the bug report template. label Feb 25, 2022
@MoltenCoffee
Copy link
Contributor

MoltenCoffee commented Feb 25, 2022

Just wanted to post the same issue! Experiencing this as well, both locally and GitHub Actions.

To further clarify:
Every instance in which a React component has children is marked as an array child without key by ESLint, including Next-buildins like next/head.

Windows 11 Education
Node v16.13.0
NPM 8.2.0
Ubuntu 20.04.3 (Github CI)
Node 16.14.0

Turning off reactStrictMode in next.config.(m)js does not help.

@wlee221
Copy link

wlee221 commented Feb 25, 2022

This is a regression from eslint-plugin-react: jsx-eslint/eslint-plugin-react#3215

@timneutkens
Copy link
Member

Handled in #34800

@SebastianSava
Copy link
Author

How long it does it take to commit this canary to stable version? I ask because on npx create-next-app@latest is still broken. @timneutkens

@balazsorban44
Copy link
Member

Already in canary https://github.com/vercel/next.js/releases/tag/v12.1.1-canary.3

latest will follow some time after.

@psudocode
Copy link

psudocode commented Feb 25, 2022

temporary fix

jsx-eslint/eslint-plugin-react#3215 (comment)

@jukialen
Copy link

I have v12.1.1-canary.3 but I still have that errors. I updated eslint-config-next to latest stable and 12.1.1-canary.3.

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

No branches or pull requests

7 participants