Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage existing component checking warning for streaming #34526

Merged
merged 5 commits into from Feb 18, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 18, 2022

Bug

Fixes: #31993

  • Remove the simple component checking in middleware ssr
  • Leverage existing components checking for Component / App / Document, if any of these component is not valid react type or is undefined nextjs will error in dev mode with redbox. Like above.

image

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 18, 2022
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 18, 2022

Failing test suites

Commit: 383f448

yarn testheadless test/integration/getinitialprops/test/index.test.js

  • getInitialProps > dev mode > should have correct router.asPath for direct visit dynamic page rewrite direct
  • getInitialProps > production mode > should have correct router.asPath for direct visit dynamic page rewrite direct
Expand output

● getInitialProps › dev mode › should have correct router.asPath for direct visit dynamic page rewrite direct

expect(received).toBe(expected) // Object.is equality

Expected: "/blog/post/1"
Received: "/blog/1"

  38 |     const html = await renderViaHTTP(appPort, '/blog/post/1')
  39 |     const $ = cheerio.load(html)
> 40 |     expect($('#as-path').text()).toBe('/blog/post/1')
     |                                  ^
  41 |   })
  42 | }
  43 |

  at Object.<anonymous> (integration/getinitialprops/test/index.test.js:40:34)

● getInitialProps › production mode › should have correct router.asPath for direct visit dynamic page rewrite direct

expect(received).toBe(expected) // Object.is equality

Expected: "/blog/post/1"
Received: "/blog/1"

  38 |     const html = await renderViaHTTP(appPort, '/blog/post/1')
  39 |     const $ = cheerio.load(html)
> 40 |     expect($('#as-path').text()).toBe('/blog/post/1')
     |                                  ^
  41 |   })
  42 | }
  43 |

  at Object.<anonymous> (integration/getinitialprops/test/index.test.js:40:34)

Read more about building and testing Next.js in contributing.md.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review February 18, 2022 14:35
@ijjk
Copy link
Member

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
buildDuration 18.6s 18.7s ⚠️ +94ms
buildDurationCached 7.5s 7.4s -174ms
nodeModulesSize 359 MB 359 MB ⚠️ +366 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
/ failed reqs 0 0
/ total time (seconds) 3.579 3.575 0
/ avg req/sec 698.6 699.24 +0.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.595 1.628 ⚠️ +0.03
/error-in-render avg req/sec 1567.22 1535.84 ⚠️ -31.38
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
buildDuration 22.5s 22.6s ⚠️ +31ms
buildDurationCached 7.4s 7.3s -41ms
nodeModulesSize 359 MB 359 MB ⚠️ +366 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
/ failed reqs 0 0
/ total time (seconds) 3.54 3.599 ⚠️ +0.06
/ avg req/sec 706.28 694.72 ⚠️ -11.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.58 1.671 ⚠️ +0.09
/error-in-render avg req/sec 1581.9 1495.95 ⚠️ -85.95
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js web-server/add-export-warning Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 30d2836

@balazsorban44 balazsorban44 changed the title Leverage existing component checking waring for streaming Leverage existing component checking warning for streaming Feb 18, 2022
@kodiakhq kodiakhq bot merged commit ce76d17 into vercel:canary Feb 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages wrapped with React.memo don’t work if concurrentFeatures is enabled
3 participants