Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure workers are not left open #34503

Merged
merged 3 commits into from Feb 18, 2022
Merged

Conversation

kinetifex
Copy link
Contributor

This fixes #33615. If an App uses getInitialProps, the build function never enters this conditional block and the static worker is left open.

@ijjk

This comment has been minimized.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ijjk
Copy link
Member

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
buildDuration 21s 20.9s -81ms
buildDurationCached 8s 7.9s -61ms
nodeModulesSize 359 MB 359 MB ⚠️ +523 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
/ failed reqs 0 0
/ total time (seconds) 4.382 4.359 -0.02
/ avg req/sec 570.54 573.54 +3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.28 2.346 ⚠️ +0.07
/error-in-render avg req/sec 1096.63 1065.58 ⚠️ -31.05
Client Bundles (main, webpack, commons)
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
buildDuration 25.5s 25.3s -219ms
buildDurationCached 7.9s 8s ⚠️ +96ms
nodeModulesSize 359 MB 359 MB ⚠️ +523 B
Page Load Tests Overall increase ✓
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
/ failed reqs 0 0
/ total time (seconds) 4.354 4.323 -0.03
/ avg req/sec 574.17 578.34 +4.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.333 2.272 -0.06
/error-in-render avg req/sec 1071.4 1100.31 +28.91
Client Bundles (main, webpack, commons)
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kinetifex/next.js fix-hanging-workers Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 6f72ed6

@kodiakhq kodiakhq bot merged commit ab40370 into vercel:canary Feb 18, 2022
@jadbox
Copy link

jadbox commented Feb 21, 2022

I think I'm still getting workers left open even on Canary right now.

@balazsorban44
Copy link
Member

Please open a bug report with a reproduction. Thanks 🙏

@vercel vercel locked as resolved and limited conversation to collaborators Feb 21, 2022
@kinetifex kinetifex deleted the fix-hanging-workers branch May 4, 2022 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom build with App getInitialProps hangs
5 participants