Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc crates #34491

Merged
merged 3 commits into from Feb 18, 2022
Merged

Update swc crates #34491

merged 3 commits into from Feb 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 17, 2022

This re-lands updating the swc crates, we should bump to include the fix for CSS minifying from here swc-project/swc#3600

#34408
#34355

Reverts #34440

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 17, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 17, 2022

Failing test suites

Commit: 1656e9b

yarn testheadless test/production/next/jest/index.test.ts

  • next/jest > should work
Expand output

● next/jest › should work

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   6 |   let next: NextInstance
   7 |
>  8 |   beforeAll(async () => {
     |   ^
   9 |     next = await createNext({
  10 |       files: {
  11 |         'components/comp.js': `

  at production/next/jest/index.test.ts:8:3
  at Object.<anonymous> (production/next/jest/index.test.ts:5:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  113 |     })
  114 |   })
> 115 |   afterAll(() => next.destroy())
      |                       ^
  116 |
  117 |   it('should work', async () => {
  118 |     const html = await renderViaHTTP(next.url, '/')

  at production/next/jest/index.test.ts:115:23

Read more about building and testing Next.js in contributing.md.

@ijjk

This comment has been minimized.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the fixes for the css issue requires different version.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will now work.

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review February 18, 2022 18:01
@ijjk
Copy link
Member Author

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
buildDuration 15.6s 15.6s ⚠️ +90ms
buildDurationCached 6.2s 6.1s -51ms
nodeModulesSize 367 MB 367 MB -7 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
/ failed reqs 0 0
/ total time (seconds) 2.968 2.986 ⚠️ +0.02
/ avg req/sec 842.37 837.3 ⚠️ -5.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.375 1.346 -0.03
/error-in-render avg req/sec 1817.98 1856.82 +38.84
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
buildDuration 19.1s 19.1s ⚠️ +15ms
buildDurationCached 6.1s 6.1s -13ms
nodeModulesSize 367 MB 367 MB -7 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
/ failed reqs 0 0
/ total time (seconds) 2.948 2.958 ⚠️ +0.01
/ avg req/sec 848.04 845.22 ⚠️ -2.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.361 1.35 -0.01
/error-in-render avg req/sec 1836.28 1852.21 +15.93
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-34440-revert/swc-css-bump Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 5f65c31

@ijjk ijjk merged commit 271dff5 into canary Feb 18, 2022
@ijjk ijjk deleted the revert-34440-revert/swc-css-bump branch February 18, 2022 20:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants