Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop exposing internal render and renderError methods from next/client #34069

Merged
merged 2 commits into from Feb 7, 2022
Merged

Stop exposing internal render and renderError methods from next/client #34069

merged 2 commits into from Feb 7, 2022

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Feb 7, 2022 •
edited

These should no longer need to be exposed.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Feb 7, 2022
@ijjk
Copy link
Member

ijjk commented Feb 7, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
buildDuration 15.6s 15.5s -92ms
buildDurationCached 6s 6s -16ms
nodeModulesSize 359 MB 359 MB -594 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.189 3.128 -0.06
/ avg req/sec 784.01 799.15 +15.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.304 1.325 ⚠️ +0.02
/error-in-render avg req/sec 1916.65 1886.09 ⚠️ -30.56
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.5 kB 27.5 kB -25 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.2 kB 71.2 kB -25 B
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.01 kB 5.01 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
index.html gzip 533 B 532 B -1 B
link.html gzip 546 B 545 B -1 B
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.6 kB -2 B

Diffs

Diff for main-HASH.js 
@@ -451,8 +451,6 @@
         value: true
       });
       exports.initNext = initNext;
-      exports.render = render;
-      exports.renderError = renderError;
       exports.emitter = exports.router = exports.version = void 0;
       __webpack_require__(37);
       var _react = _interopRequireWildcard1(__webpack_require__(7294));
@@ -1062,6 +1060,9 @@
       function render(renderingProps) {
         return _render.apply(this, arguments);
       }
+      // This method handles all runtime and debug errors.
+      // 404 and 500 errors are special kind of errors
+      // and they are still handle via the main render method.
       function renderError(renderErrorProps) {
         var App = renderErrorProps.App,
           err = renderErrorProps.err;
@@ -1499,9 +1500,7 @@
         get router() {
           return _.router;
         },
-        emitter: _.emitter,
-        render: _.render,
-        renderError: _.renderError
+        emitter: _.emitter
       };
       (0, _).initNext().catch(console.error); //# sourceMappingURL=next.js.map
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-3720cf9ee02892d9.js"
+      src="/_next/static/chunks/main-3f410c6ef50aaf2d.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-3720cf9ee02892d9.js"
+      src="/_next/static/chunks/main-3f410c6ef50aaf2d.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-3720cf9ee02892d9.js"
+      src="/_next/static/chunks/main-3f410c6ef50aaf2d.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
buildDuration 18.7s 19s ⚠️ +306ms
buildDurationCached 6s 6.1s ⚠️ +109ms
nodeModulesSize 359 MB 359 MB -594 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.154 3.181 ⚠️ +0.03
/ avg req/sec 792.61 785.89 ⚠️ -6.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.331 1.356 ⚠️ +0.03
/error-in-render avg req/sec 1878.61 1843.48 ⚠️ -35.13
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.1 kB 42.1 kB ✓
main-HASH.js gzip 27.6 kB 27.5 kB -26 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB -26 B
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.28 kB 2.28 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-rm-exposed-render-funcs Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 528 B ⚠️ +1 B
Overall change 1.61 kB 1.61 kB ⚠️ +1 B

Diffs

Diff for main-HASH.js 
@@ -451,8 +451,6 @@
         value: true
       });
       exports.initNext = initNext;
-      exports.render = render;
-      exports.renderError = renderError;
       exports.emitter = exports.router = exports.version = void 0;
       __webpack_require__(37);
       var _react = _interopRequireWildcard1(__webpack_require__(7294));
@@ -1062,6 +1060,9 @@
       function render(renderingProps) {
         return _render.apply(this, arguments);
       }
+      // This method handles all runtime and debug errors.
+      // 404 and 500 errors are special kind of errors
+      // and they are still handle via the main render method.
       function renderError(renderErrorProps) {
         var App = renderErrorProps.App,
           err = renderErrorProps.err;
@@ -1499,9 +1500,7 @@
         get router() {
           return _.router;
         },
-        emitter: _.emitter,
-        render: _.render,
-        renderError: _.renderError
+        emitter: _.emitter
       };
       (0, _).initNext().catch(console.error); //# sourceMappingURL=next.js.map
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-3720cf9ee02892d9.js"
+      src="/_next/static/chunks/main-3f410c6ef50aaf2d.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-3720cf9ee02892d9.js"
+      src="/_next/static/chunks/main-3f410c6ef50aaf2d.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-3720cf9ee02892d9.js"
+      src="/_next/static/chunks/main-3f410c6ef50aaf2d.js"
       defer=""
     ></script>
     <script
Commit: edfc49b

@devknoll devknoll marked this pull request as ready for review February 7, 2022 20:03
@devknoll devknoll changed the title Stop exposing internal render and renderError methods Stop exposing internal render and renderError methods from next/client Feb 7, 2022
@kodiakhq kodiakhq bot merged commit c0dc008 into vercel:canary Feb 7, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@devknoll @natew
Stop exposing internal render and renderError methods from `next/…
130cd5c 
…client` (vercel#34069)

These should no longer need to be exposed.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devknoll @ijjk @huozhi