Generate functions manifest #33770

huozhi · 2022-01-28T17:13:56Z

Feature

Reuse most of the part from manifest plugin to generate similar assets

Resolves #33667

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added

packages/next/build/webpack-config.ts

packages/next/build/webpack/plugins/functions-manifest-plugin.ts

shuding

The next step is to create different types of entries (lambda/edge function) and let the plugin to generate different runtimes in the manifest.

ijjk · 2022-01-31T15:30:25Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	huozhi/next.js func-manifest	Change
buildDuration	12.4s	12.3s	-41ms
buildDurationCached	3.1s	3.2s	⚠️ +25ms
nodeModulesSize	358 MB	358 MB	⚠️ +5.68 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	huozhi/next.js func-manifest	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.885	2.887	0
/ avg req/sec	866.64	865.93	⚠️ -0.71
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.378	1.39	⚠️ +0.01
/error-in-render avg req/sec	1814.3	1798.75	⚠️ -15.55

Client Bundles (main, webpack, commons)

	vercel/next.js canary	huozhi/next.js func-manifest	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71 kB	71 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js func-manifest	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js func-manifest	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.93 kB	4.93 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.3 kB	14.3 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js func-manifest	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js func-manifest	Change
index.html gzip	530 B	530 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	huozhi/next.js func-manifest	Change
buildDuration	15.7s	15.8s	⚠️ +42ms
buildDurationCached	3.2s	3.2s	-9ms
nodeModulesSize	358 MB	358 MB	⚠️ +5.68 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	huozhi/next.js func-manifest	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.92	2.927	⚠️ +0.01
/ avg req/sec	856.25	854.26	⚠️ -1.99
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.355	1.358	0
/error-in-render avg req/sec	1845.33	1840.85	⚠️ -4.48

Client Bundles (main, webpack, commons)

	vercel/next.js canary	huozhi/next.js func-manifest	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.3 kB	27.3 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js func-manifest	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js func-manifest	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	4.97 kB	4.97 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.21 kB	2.21 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.3 kB	14.3 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js func-manifest	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js func-manifest	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 7cbd489

## Feature Follow up for #33770 * When page config specify runtime is "nodejs", remove runtime option in functions manifest; * If user enable `concurrentFeatures` and filesystem api, use `runtime: "web"` for those pages; - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [x] Integration tests added

## Feature Reuse most of the part from manifest plugin to generate similar assets Resolves vercel#33667 - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [x] Integration tests added

## Feature Follow up for vercel#33770 * When page config specify runtime is "nodejs", remove runtime option in functions manifest; * If user enable `concurrentFeatures` and filesystem api, use `runtime: "web"` for those pages; - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [x] Integration tests added

Generate functions manifest

4919918

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 28, 2022

This comment has been minimized.

Sign in to view

group options

d8e1119

This comment has been minimized.

Sign in to view

Write manifest only when filesystem api is enabled

be6d806

This comment has been minimized.

Sign in to view

huozhi marked this pull request as ready for review January 31, 2022 14:16

huozhi requested review from ijjk, padmaia, shuding and timneutkens as code owners January 31, 2022 14:16

shuding reviewed Jan 31, 2022

View reviewed changes

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

shuding reviewed Jan 31, 2022

View reviewed changes

packages/next/build/webpack/plugins/functions-manifest-plugin.ts Outdated Show resolved Hide resolved

only build functions manifest with server files

8abc5f8

huozhi requested a review from shuding January 31, 2022 14:35

This comment has been minimized.

Sign in to view

shuding approved these changes Jan 31, 2022

View reviewed changes

Merge branch 'canary' into func-manifest

7cbd489

kodiakhq bot merged commit 5b31c18 into vercel:canary Jan 31, 2022

huozhi deleted the func-manifest branch January 31, 2022 16:10

huozhi mentioned this pull request Feb 3, 2022

Detect per page runtime config for functions manifest #33945

Merged

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate functions manifest #33770

Generate functions manifest #33770

huozhi commented Jan 28, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

shuding left a comment

ijjk commented Jan 31, 2022

Generate functions manifest #33770

Generate functions manifest #33770

Conversation

huozhi commented Jan 28, 2022

Feature

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

shuding left a comment

Choose a reason for hiding this comment

ijjk commented Jan 31, 2022

Stats from current PR