[example] Upgrade the with-stripe-typescript example app #33761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe-typescript examples
…with-stripe-typescript examples
hideokamoto-stripe
requested review from
ijjk,
leerob,
shuding,
steven-tey and
timneutkens
as code owners
leerob
approved these changes
Jan 28, 2022
| const { error } = await stripe!.confirmPayment({ | ||
| elements, | ||
| confirmParams: { | ||
| return_url: 'http://localhost:3000/donate-with-elements', |
There was a problem hiding this comment.
Should this be hard coded to localhost?
There was a problem hiding this comment.
It's a URL of the redirect destination.
So if we can set the current page url, we don't have to hard code it.
eg.)
return_url: window && window.location ? [location.protocol, location.hostname,'donate-with-elements'].join('/') ; 'http://localhost:3000/donate-with-elements'
But, it this example works well in SSG/SSR mode?
That's my worrying.
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
Hi team! I found in the `with-stripe-typescript` example that I need to update these things. - `use-shopping-cart` is launched a new major version - Stripe launched a new useful payment element named Stripe Payment Element So I've updated the example app to support these updates. ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint` ## How to test it Please check the README.md of the example. https://github.com/vercel/next.js/blob/canary/examples/with-stripe-typescript/README.md Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team!
I found in the
with-stripe-typescriptexample that I need to update these things.use-shopping-cartis launched a new major versionSo I've updated the example app to support these updates.
Documentation / Examples
yarn lintHow to test it
Please check the README.md of the example.
https://github.com/vercel/next.js/blob/canary/examples/with-stripe-typescript/README.md
Thanks!